Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use accessor for inverse-bind matrices #238

Closed
pjcozzi opened this issue Feb 25, 2014 · 3 comments
Closed

Use accessor for inverse-bind matrices #238

pjcozzi opened this issue Feb 25, 2014 · 3 comments
Labels

Comments

@pjcozzi
Copy link
Member

pjcozzi commented Feb 25, 2014

Inverse-bind matrices for a skin currently look like:

        "Controller-mesh019": {
            "bindShapeMatrix": [
                // ...
            ],
            "inverseBindMatrices": {
                "bufferView": "bufferView_465",
                "byteOffset": 0,
                "count": 19,
                "type": 35676
            },
            "joints": [
                // ...
            ]
        }

Shouldn't we make inverseBindMatrices just reference an accessor, e.g.,

    "accessors": {
        "accessor_10": {
            "bufferView": "bufferView_465",
            "byteOffset": 0,
            "count": 19,
            "type": 35676
        },
@fabrobinet
Copy link
Contributor

yes - good catch

@pjcozzi
Copy link
Member Author

pjcozzi commented Feb 25, 2014

I will write the schema using accessors then. Can this make dev-6 to keep everything in sync?

@pjcozzi
Copy link
Member Author

pjcozzi commented Aug 27, 2015

The schema and converter are updated and in-sync.

@pjcozzi pjcozzi closed this as completed Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants