-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid fields in sample models #556
Comments
Good catch, thanks @lexaknyazev! @tfili I noticed this in several sample models, including some from Cesium (but not all). Do you think these were converted with an old version of COLLADA2GLTF or is this still a bug in COLLADA2GLTF? In either case, can you update the models, including the glb versions? @lexaknyazev - btw, what glTF loader are you working on? |
Just tested other samples (except
Here is validator's output:
|
While implementing
|
Thanks for the reports, @lexaknyazev! We'll update everything (give us some time though please). Continue to update this issue if you find anything else. |
Couple more:
Only new issues listed below.
|
Thanks for these! |
There's the same issue with lots of |
There's some ambiguity behind it: |
In many samples, primitive attributes reference
|
Thanks again @lexaknyazev! Have you built a glTF validator? If so, do you plan to make it open source? Khronos is interested in a tool like this, see #557. |
@pjcozzi Eventually loader became a some sort of validation tool. Supports all extensions from the registry ( At the moment it's just a command line tool. However, I've made a simple client-side web wrapper: It can crash on some edge cases since I haven't achieved full code coverage yet. There are also several spec issues which need some attention to make validation more robust. |
Wow, sounds great @lexaknyazev!
Can you please submit a separate issue for these? We are very interested in tightening up the spec to support validation. This could, for example, be glTF 1.0.1. Also, would you be interested in discussing the possibility of making your validator the official glTF validator? Khronos has an RFQ out to fund this effort (#557). Email me if you want to learn more, pjcozzi@gmail.com |
|
@lexaknyazev the sample model fixes are in #579 thanks to @lasalvavida. Please feel free to review and comment in that PR if you have the time. Thanks again for all your feedback here! |
@lexaknyazev closed this via #579. Let us know if you run into any other issues with the sample models. |
I've found some invalid data in sampleModels/duck/glTF/duck.gltf while testing my glTF loader.
asset.version
isint
instead ofstring
L72aspectRatio
is spelled asaspect_ratio
L99The text was updated successfully, but these errors were encountered: