Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSFT_audio_emitter extension #1400

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

najadojo
Copy link

We at Microsoft have been developing this extension for use in various products and scenarios. We are sharing to document software we will be shipping and to get feedback on the extension design. Its possible that this extension maybe useful for other vendors as evidenced by #753.

@lexaknyazev
Copy link
Member

May I nitpick about audio data formats?

  • Why it's only audio/wav?
  • According to IANA registry, audio/wav is not a valid registered MIME type (despite being widely used). Other seen options are audio/vnd.wave and audio/x-wav.
  • Assuming that WAV means RIFF container, which of many possible WAV encodings are supposed to be supported?

@najadojo
Copy link
Author

We picked wav because its commonly available and trivial to decode almost anywhere. Continuing with the runtime friendliness of glTF and the desire to use linear PCM decoded audio data at runtime it made reasonable sense. Our least capable client is able to decode wav with WAVE_FORMAT_PCM, and WAVE_FORMAT_IEEE_FLOAT. I'll update the mime type value.

@najadojo
Copy link
Author

I created a demo video that shows how this extension can be used in Babylon.js.

@pjcozzi
Copy link
Member

pjcozzi commented Jul 19, 2018

@amwatson and @tparisi had an interest in spatialized audio a couple of years ago, #753. Perhaps they want to chime in here?

@pjcozzi
Copy link
Member

pjcozzi commented Jan 25, 2019

@najadojo is this spec/schema still up-to-date with the Babylon implementation?

@sbtron @lexaknyazev OK to merge from your perspective? Perhaps the samples belong in the glTF-Sample-Models repo?

@najadojo
Copy link
Author

Yes Babylon.js and Windows Mixed Reality are using this extension as its presented here.

@pjcozzi
Copy link
Member

pjcozzi commented Jan 25, 2019

@najadojo very nice!

@sbtron @lexaknyazev please merge when you are ready.

@merlosy
Copy link

merlosy commented Mar 2, 2022

I'm interested in this feature :) plz

I don't know if you knew: Babylonjs has already implemented it: https://viewer.babylonjs.com/ufoexample

@robertlong robertlong mentioned this pull request Mar 31, 2022
@faridskyman
Copy link

Video demo was great, having a 3d object with animation that also plays sounds is a terrific idea. However this thread is dead, Khronos people? what happen? u guys dont like this? then do u have a better idea? or no action?
can we have this or u guys comeout with a standard?
else its strange, we get user to upload audio and we try to sync with with the animation?
dont seem a good idea..
hope khoronos will reconsider.. its 2022, 4 years has passed...

@bghgary
Copy link
Contributor

bghgary commented Jun 27, 2022

See #2137.


#### emitter.outerAngle

The cone will be symmetrical and face the forward direction (Z+). The outerAngle value must be greater than or equal to the innerAngle value. If neither innerAngle or outerAngle are defined the emitter will behave as an omnidirectional source.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inconsistent with KHR_lights_punctual which defines spotlights as facing -Z. Is it expected that conical audio should be pointing the opposite direction as conical lights?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants