Added support for LINES primitives #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabrobinet it would help us if you could merge this soon and handle compression in a separate issue. This is definitely a welcomed incremental change. |
|
@pjcozzi that is exactly my intention. |
|
it's also last fix for dev-7 |
|
tracking compression of lines here: https://github.com/amd/rest3d/issues/42 |
fabrobinet
added a commit
that referenced
this pull request
Jul 14, 2014
Added support for LINES primitives
|
track the compression enabled for lines in glTF here: #303 |
|
Thanks @fabrobinet @tfili @fabrobinet will you merge dev-7 to master today? |
|
@pjcozzi that is the plan, doing some tests now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#129
It adds code to divide line meshes but doesn't include compression code for lines.