Fixed CG_profile effect. Default material applied in this case #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lasalvavida can you please test, review, and merge this? |
|
@mycheckgithub Do you have a sample model you could share that doesn't convert correctly currently? |
|
Here is a sample model: |
|
Any news about merging ? |
|
@lasalvavida can you look at this when you do the COLLADA2GLTF updates for 1.0.1? |
|
Closed due to moving COLLADA2GLTF into separate repo. CC @lasalvavida |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openCOLLADA, which is the core library used by glTF converter, does not seem capable to load the profile_CG data from the COLLADA file, which in turns makes it very difficult for the glTF converter to not behave correctly.
To have the gltf converter not to crash, this fix will create a defaultMaterial in this case.