Fixed ordering of blendFuncSeparate #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice catch, Please update the schema as well: https://github.com/KhronosGroup/glTF/blob/master/specification/schema/technique.states.functions.schema.json#L44 Looks like the example is OK: https://github.com/KhronosGroup/glTF/blob/master/specification/schema/examples/techniques.json Did you also spot check the models in the |
|
Related: #585 |
|
@pjcozzi Thanks for noticing those other areas. My update fixes the remaining issues. The sample models are all fine. |
lexaknyazev
pushed a commit
that referenced
this pull request
Feb 2, 2017
Fixed ordering of blendFuncSeparate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering was incorrect in this area. Uncovered through this post on the Cesium forum: https://groups.google.com/forum/#!msg/cesium-dev/BP_fs8K19ww/n2SBwzEsBAAJ