Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming scheme for light properties in KHR_materials_common #780

Closed
wants to merge 1 commit into from
Closed

naming scheme for light properties in KHR_materials_common #780

wants to merge 1 commit into from

Conversation

xelatihy
Copy link
Contributor

In the schema for KHR_materials_common extension, light filenames names where defined as

light.XXX.schema.json

For consistency with the other schemas, I suggest to rename them with

light.XXX. KHR_materials_common.schema.json

This naming convention has the following benefits:

  1. automatic code generation from the schema have the same names for properties in both lights and materials
  2. should be backward compatible in validation

@pjcozzi
Copy link
Member

pjcozzi commented Dec 28, 2016

Thanks @xelatihy, sorry for the slow response.

@lexaknyazev this change is OK with me but is it OBE given #632 (comment)?

@lexaknyazev lexaknyazev closed this Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants