Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting GL_ARB_arrays_of_arrays #1057

Closed
haasn opened this issue Sep 13, 2017 · 3 comments
Closed

Allow setting GL_ARB_arrays_of_arrays #1057

haasn opened this issue Sep 13, 2017 · 3 comments
Labels
enhancement GLSL/ESSL

Comments

@haasn
Copy link
Contributor

haasn commented Sep 13, 2017

from glslangValidator master:

WARNING: /tmp/ravk.glsl:3: '#extension' : extension not supported: GL_ARB_arrays_of_arrays

https://www.khronos.org/registry/OpenGL/extensions/ARB/ARB_arrays_of_arrays.txt
haasn added a commit to haasn/mp that referenced this issue Sep 17, 2017
@haasn
vo_gpu: drop the RA_CAP_NESTED_ARRAY req from EWA compute
c3a9fc4 
Almost as fast as the old code, but more general. Notably, glslang
doesn't support nested arrays.

(cf. KhronosGroup/glslang#1057)

Also much cleaner code-wise, so I think I'll keep it even if glslang
implements array_of_arrays.
haasn added a commit to haasn/mp that referenced this issue Sep 18, 2017
@haasn
vo_gpu: drop the RA_CAP_NESTED_ARRAY req from EWA compute
613aa15 
Almost as fast as the old code, but more general. Notably, glslang
doesn't support nested arrays.

(cf. KhronosGroup/glslang#1057)

Also much cleaner code-wise, so I think I'll keep it even if glslang
implements array_of_arrays.
haasn added a commit to haasn/mp that referenced this issue Sep 20, 2017
@haasn
vo_gpu: drop the RA_CAP_NESTED_ARRAY req from EWA compute
6d59d2e 
Almost as fast as the old code, but more general. Notably, glslang
doesn't support nested arrays.

(cf. KhronosGroup/glslang#1057)

Also much cleaner code-wise, so I think I'll keep it even if glslang
implements array_of_arrays.
haasn added a commit to haasn/mp that referenced this issue Sep 20, 2017
@haasn
vo_gpu: drop the RA_CAP_NESTED_ARRAY req from EWA compute
9afd036 
Almost as fast as the old code, but more general. Notably, glslang
doesn't support nested arrays.

(cf. KhronosGroup/glslang#1057)

Also much cleaner code-wise, so I think I'll keep it even if glslang
implements array_of_arrays.
haasn added a commit to haasn/mp that referenced this issue Sep 20, 2017
@haasn
vo_gpu: drop the RA_CAP_NESTED_ARRAY req from EWA compute
4cbe4f0 
Almost as fast as the old code, but more general. Notably, glslang
doesn't support nested arrays.

(cf. KhronosGroup/glslang#1057)

Also much cleaner code-wise, so I think I'll keep it even if glslang
implements array_of_arrays.
haasn added a commit to haasn/mp that referenced this issue Sep 20, 2017
@haasn
vo_gpu: drop the RA_CAP_NESTED_ARRAY req from EWA compute
52dc743 
Almost as fast as the old code, but more general. Notably, glslang
doesn't support nested arrays.

(cf. KhronosGroup/glslang#1057)

Also much cleaner code-wise, so I think I'll keep it even if glslang
implements array_of_arrays.
haasn added a commit to mpv-player/mpv that referenced this issue Sep 21, 2017
@haasn
vo_gpu: drop the RA_CAP_NESTED_ARRAY req from EWA compute
b940691 
Almost as fast as the old code, but more general. Notably, glslang
doesn't support nested arrays.

(cf. KhronosGroup/glslang#1057)

Also much cleaner code-wise, so I think I'll keep it even if glslang
implements array_of_arrays.
@haasn
Copy link
Contributor Author

haasn commented Sep 23, 2017 •
edited

I'd like to point out that it seems glslang actually does support nested arrays, it just doesn't advertise support for the extension. That is, the #extension pragma gets rejected, but just omitting the extension line makes it work fine.

So this issue is simpler than we thought, and glslang just needs to get smart enough to accept the #extension.

@haasn haasn changed the title Implement GL_ARB_arrays_of_arrays Allow setting GL_ARB_arrays_of_arrays Sep 23, 2017
@haasn
Copy link
Contributor Author

haasn commented Oct 14, 2017

GL_ARB_shader_storage_buffer_object is also rejected even though it should work fine.

@greg-lunarg
Copy link
Contributor

Closed as duplicate to #2649

@greg-lunarg greg-lunarg mentioned this issue May 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement GLSL/ESSL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@haasn @johnkslang @greg-lunarg