error: 'operator=' is a private member of 'glslang::TPoolAllocator'

[PiJoules]

It seems that pool_allocator is attempting to assign a TPoolAllocator even though the TPoolAllocator assignment operator is private.

  FAILED: host_x64-asan/obj/third_party/shaderc/libshaderc_util/src/shaderc_util_sources.compiler.o
  /b/s/w/ir/k/recipe_cleanup/clangUy7JlV/bin/clang++ -MD -MF host_x64-asan/obj/third_party/shaderc/libshaderc_util/src/shaderc_util_sources.compiler.o.d -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -I../.. -Ihost_x64-asan/gen -I../../third_party/shaderc/libshaderc_util/include -I../../third_party/glslang -I../../third_party/spirv-tools/include -fcolor-diagnostics -fcrash-diagnostics-dir=clang-crashreports --sysroot=/b/s/w/ir/k/prebuilt/third_party/sysroot/linux --target=x86_64-linux-gnu -fdebug-prefix-map=/b/s/w/ir/k/out/default=. -fdebug-prefix-map=/b/s/w/ir/k/out=.. -fdebug-prefix-map=/b/s/w/ir/k=../.. -no-canonical-prefixes -fomit-frame-pointer -g3 -Wall -Wextra -Wnewline-eof -Wno-unused-parameter -Wno-unknown-warning-option -Wno-implicit-int-float-conversion -fvisibility=hidden -O0 -fsanitize=address -fno-omit-frame-pointer -fvisibility-inlines-hidden -std=c++17 -stdlib=libc++ -fno-exceptions -fno-rtti -c ../../third_party/shaderc/libshaderc_util/src/compiler.cc -o host_x64-asan/obj/third_party/shaderc/libshaderc_util/src/shaderc_util_sources.compiler.o
  In file included from ../../third_party/shaderc/libshaderc_util/src/compiler.cc:29:
  In file included from ../../third_party/glslang/SPIRV/GlslangToSpv.h:42:
  In file included from ../../third_party/glslang/SPIRV/SpvTools.h:47:
  In file included from ../../third_party/glslang/SPIRV/../glslang/MachineIndependent/localintermediate.h:42:
  In file included from ../../third_party/glslang/glslang/Public/../MachineIndependent/../Include/intermediate.h:55:
  In file included from ../../third_party/glslang/glslang/Public/../Include/../Include/Common.h:108:
  ../../third_party/glslang/glslang/Public/../Include/PoolAlloc.h:307:54: error: 'operator=' is a private member of 'glslang::TPoolAllocator'
  void setAllocator(TPoolAllocator* a) { allocator = *a; }
  ~~~~~~~~~ ^ ~~
  ../../third_party/glslang/glslang/Public/../Include/PoolAlloc.h:244:21: note: declared private here
  TPoolAllocator& operator=(const TPoolAllocator&);  // don't allow assignment operator
  ^
  1 error generated.

Something else that's also weird: It seems that PoolAlloc.hhasn't been touched since 2017, so I'm wondering how this went uncaught for a while.

[PiJoules]

Ah so I hadn't noticed this earlier, but this error will only be raised if setAllocator is called since it is a non-virtual function of a templated class. It could be that another one of our third party libraries that uses glslang (shaderc in this case) ended up calling setAllocator and caused the error to manifest.

The reason it might've gone unnoticed is because it seems setAllocator isn't being used in glslang internally (as far as a github query tells me).

Not sure if this needs to be changed, but I'll keep this issue open in the meantime.

[johnkslang]

It seems like setAllocator couldn't be called either. This is removed by #2010. If that really does break something, make an issue that we need to add that functionality some other way.