v14 doesn't install required headers

[dmanlfc]

apps that build against glslang cannot find the headers, turns out they're not installed.

my fix...

diff --git a/glslang/CMakeLists.txt b/glslang/CMakeLists.txt
index 37eecaadd4..0e9037bf7a 100644
--- a/glslang/CMakeLists.txt
+++ b/glslang/CMakeLists.txt
@@ -254,11 +254,8 @@ if(PROJECT_IS_TOP_LEVEL)
 
     set(PUBLIC_HEADERS
         Public/ResourceLimits.h
-        Public/ShaderLang.h
         Public/resource_limits_c.h
-        Include/glslang_c_interface.h
-        Include/glslang_c_shader_types.h
-        Include/ResourceLimits.h
+        ${GLSLANG_HEADERS}
         MachineIndependent/Versions.h)
 
     foreach(file ${PUBLIC_HEADERS})

[FireBurn]

It looks like it was deliberate 1dcb072 #3397

[arcady-lunarg]

Could you list which headers you are using that aren't being installed? We are certainly open to tweaking the set of installed headers, though we still would prefer not to install absolutely everything by default.

[dmanlfc]

@arcady-lunarg unfortunately the downstream package Cemu required most to be reinstated. Hence using ${GLSLANG_HEADERS

[arcady-lunarg]

From a quick grep through the source at https://github.com/cemu-project/Cemu, I see that it does depend on glslang and its header files but only uses glslang/Public/ShaderLang.h and glslang/SPIRV/GlslangToSpv.h, both of which are in the set that are installed.

[dmanlfc]

Actually it doesn't. It requests Types, Common, ResourcesLimits etc. I would have had to make the change if everything was provided.

[dmanlfc]

Note, they have just added a commit to move to using the Public Headers.

[FireBurn]

That was me

[arcady-lunarg]

Sounds like just using the public headers was fine then, I'm going to close this issue.