Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untangle build target cyclic dependencies #2267

Closed
wants to merge 3 commits into from
Closed

Untangle build target cyclic dependencies #2267

wants to merge 3 commits into from

Commits on Jun 10, 2020

  1. Fix signed / unsigned mismatch warning

    @ben-clayton
    ben-clayton committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    6da9212 View commit details
    Browse the repository at this point in the history

  2. C Interface: Split SPIR-V C interface to own file 

    This breaks a cyclic dependency between the SPIRV and glslang build targets.
    @ben-clayton
    ben-clayton committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    45de441 View commit details
    Browse the repository at this point in the history

  3. Add glslang::Language to break cyclic dependency 

    between `HLSL` and `glslang` build targets.

Applications now require a call to `glslang::RegisterHlslLanguage()`
to enable support for the HLSL language.
This is implemented in the HLSL library.

Fixes building of shared libraries.
    @ben-clayton
    ben-clayton committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    0b6ece0 View commit details
    Browse the repository at this point in the history