Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kokoro: Run tests for CMake builds #2336

Closed

Conversation

ben-clayton
Copy link
Contributor

No description provided.

@ben-clayton ben-clayton force-pushed the kokoro-cmake-runtests branch 5 times, most recently from 0655c22 to c3c10b1 Compare July 13, 2020 15:39
@ben-clayton
Copy link
Contributor Author

Tests are failing with:

Testing SPV Debug Information
2,3d1
< error: SPIRV-Tools Validation Errors
< error: Invalid SPIR-V binary version 1.3 for target environment SPIR-V 1.0 (under OpenGL 4.5 semantics).

Which I also observe locally.

@johnkslang
Copy link
Member

I randomly checked CI-ubuntu-gcc-cmake-static. It keeps reporting:

../build/install/bin/glslangValidator: error while loading shared libraries: libglslang.so.10

when trying to execute the tests. It earlier said:

CMake Warning (dev) at /bin/cmake-3.17.2/share/cmake-3.17/Modules/GNUInstallDirs.cmake:225 (message):
  Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
  target architecture is known.  Please enable at least one language before
  including GNUInstallDirs.

I see CI-ubuntu-gcc-cmake-static reporting the 1.3 vs. 1.0 thing. The debug block runs 3 tests, and the middle one is indeed making SPIR-V 1.3. Maybe it's telling the validator it made 1.0, and the validator complains? But, I don't see that locally, nor in the last commit to master, so it must also be about something being out of date somewhere.

@ben-clayton
Copy link
Contributor Author

ben-clayton commented Jul 13, 2020

I randomly checked CI-ubuntu-gcc-cmake-static. It keeps reporting:

You mean CI-ubuntu-gcc-cmake-shared, right? Good spot - I need to set LD_LIBRARY_PATH due to the non-standard install path. Edit: Done

As for the CMAKE_INSTALL_LIBDIR warning - I'll take a look. I vaguely remember this being raised before I started working on the shared libs, but I'll investigate all the same. Edit: See #2339

@ben-clayton
Copy link
Contributor Author

As for the:

Testing SPV Debug Information
2,3d1
< error: SPIRV-Tools Validation Errors
< error: Invalid SPIR-V binary version 1.3 for target environment SPIR-V 1.0 (under OpenGL 4.5 semantics).

This is failing because these two lines are expected but aren't actually emitted any more. Has something been relaxed recently?

@ben-clayton
Copy link
Contributor Author

Oh hold on - these Kokoro tests aren't calling update_glslang_sources.py - by not having these in External/, are we disabling validation or something?

@johnkslang
Copy link
Member

Yes, if SPIR-V tools are not present, glslang operates anyway, without them, or links to them from another location, which might pick up the wrong version.

@ben-clayton ben-clayton marked this pull request as ready for review July 22, 2020 11:13
@ben-clayton ben-clayton marked this pull request as draft July 31, 2020 06:23
@ben-clayton
Copy link
Contributor Author

Switched to draft due to #2361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants