-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kokoro: Run tests for CMake builds #2336
Conversation
0655c22
to
c3c10b1
Compare
Tests are failing with:
Which I also observe locally. |
I randomly checked CI-ubuntu-gcc-cmake-static. It keeps reporting:
when trying to execute the tests. It earlier said:
I see CI-ubuntu-gcc-cmake-static reporting the 1.3 vs. 1.0 thing. The debug block runs 3 tests, and the middle one is indeed making SPIR-V 1.3. Maybe it's telling the validator it made 1.0, and the validator complains? But, I don't see that locally, nor in the last commit to master, so it must also be about something being out of date somewhere. |
You mean CI-ubuntu-gcc-cmake-shared, right? Good spot - I need to set As for the |
c3c10b1
to
dc27f12
Compare
As for the:
This is failing because these two lines are expected but aren't actually emitted any more. Has something been relaxed recently? |
Oh hold on - these Kokoro tests aren't calling |
Yes, if SPIR-V tools are not present, glslang operates anyway, without them, or links to them from another location, which might pick up the wrong version. |
41aaef7
to
b2ce4d1
Compare
d14955c
to
6abc1e7
Compare
6bd911b
to
d61b66e
Compare
d61b66e
to
6fd45cd
Compare
6fd45cd
to
96da92d
Compare
Switched to draft due to #2361 |
No description provided.