Simplify PoolAlloc by using thread_local
#2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
glslang is using C++ 11, which has first class support for variables of the `thread_local` storage class. By dropping the use of the `OS_[GS]etTLSValue`, we can simplify the logic, and have it support a thread-local default allocator if none is provided. Issue: KhronosGroup#2346
These were only used for TThreadPool, which now uses `thread_local`.
ben-clayton
force-pushed
the
thread-local
branch
from
5b5522e
to
abf92c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++11 supports
thread_localstorage class, which means we can drop the use of OS-bespokeOS_*TLSIndexfunctions.This greatly simplifies fixing #2346.
Note:
thread_localwas not properly supported in Visual Studio 2013, so I've had to bump appveyor to use Visual Studio 2015.Visual Studio 2013 is scheduled to be deprecated on July 20th 2020, so this should probably not land until then.