Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix per-set argument parsing in standalone #2704

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Fix per-set argument parsing in standalone #2704

merged 1 commit into from
Jul 27, 2021

Conversation

YunHsiao
Copy link
Contributor

@YunHsiao YunHsiao commented Jul 26, 2021 •
edited
Loading

Currently usages like this don't work at all:

glslangValidator -V --shift-UBO-binding 16 1 # add offset 16 to set 1 only

Seems to be a simple parsing problem.

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@greg-lunarg greg-lunarg added the kokoro:run Trigger Google bot runs label Jul 27, 2021
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Jul 27, 2021
@greg-lunarg
Copy link
Contributor

LGTM. Thanks for the fix.

@greg-lunarg greg-lunarg merged commit 1978c76 into KhronosGroup:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YunHsiao @CLAassistant @greg-lunarg @kokoro-team