Fix: Build arm64 binaries for macOS #2988
Conversation
spnda
force-pushed
the
build_arm64_binaries_mac
branch
from
beaeea8
to
b43848f
Compare
|
Continuous deployment tests failed for macOS-11 arm64. The glslang-testsuite failed with multiple such failures: /Users/runner/work/glslang/glslang/build/StandAlone/glslangValidator: Bad CPU type in executable The glslang-testsuites test failed with BAD_COMMAND I will have to revert until we have fixes for this. |
|
@greg-lunarg This PR makes it build arm64 binaries. However, the macos-11 and macos-12 GH runners are running on x86_64. They simply cannot run arm64 binaries. The only options currently (besides reverting) would be to either drop tests when running arm64 (easily done by an if condition in the yaml), or wait until GitHub provides arm64-based runners. I personally don't think dropping tests in this case is bad, as they still run and do their job on ubuntu, macos (x86_64), and windows and I don't think there's any architecture exclusive code in the glslang source. And for the GH hosted runners, this may take a while because up until now they've been quite hesitant offering any arm64 runners. |
|
@spnda I am going to revert until I have come to a decision about how to handle this situation. |
x86_64 binaries cannot be linked when building solely for arm64. This uses the matrix to build separately for x86_64 and arm64. I specifically opted for this instead of building a universal binary as there seems to be no guarantee that universal binary 2 files can be read and understood by older linkers, and the fact that a universal binary will effectively have two copies of the library/executable wasting a considerable amount of space. Also, upgrading the runner to
macOS-11in 457d11e was required for this to work.