Extend the syntax of #line and __FILE__ to support filename strings #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the GLSL spec, the second parameter to #line should be an integer source string number and __FILE__ will be substituted with the integer source string number currently processed. This patch extends the syntax of #line and __FILE__. Now #line accepts as the second parameter a filename string quoted by double quotation marks. And if such a #line is set, __FILE__ will be substituted with the currently set filename string. The implementation is done via introducing a new extension GL_GOOGLE_cpp_style_line_directive using the extension framework. The purpose is to support cpp-style #line directives, which is required by #include.
antiagainst
force-pushed
the
cpp-style-line-directive
branch
from
fe3a743
to
5011fbe
Compare
|
Of course. On it. |
Use requireExtensions() to check GL_GOOGLE_cpp_style_line_directive is turned on. Add register more tests for running.
|
Added two more commits to address the issues. |
johnkslang
added a commit
that referenced
this pull request
Jul 29, 2015
Extend the syntax of #line and __FILE__ to support filename strings. The implementation is done via introducing a new extension GL_GOOGLE_cpp_style_line_directive using the extension framework. The purpose is to support cpp-style #line directives, which is required by #include.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the GLSL spec, the second parameter to
#lineshould bean integer source string number and
__FILE__will be substitutedwith the integer source string number currently processed. This
patch extends the syntax of
#lineand__FILE__. Now#lineacceptsas the second parameter a filename string quoted by double quotation
marks. And if such a
#lineis set,__FILE__will be substituted withthe currently set filename string. The implementation is done via
introducing a new extension
GL_GOOGLE_cpp_style_line_directiveusingthe extension framework.
The purpose is to support
cpp-style#linedirectives, which isrequired by
#include.This commit falls into the second step listed in Issue #37.