Skip to content
This repository has been archived by the owner on Nov 21, 2017. It is now read-only.

Fix KLC and extend pinheader library #17

Merged
merged 6 commits into from
Dec 27, 2016
Merged

Fix KLC and extend pinheader library #17

merged 6 commits into from
Dec 27, 2016

Conversation

jkriege2
Copy link
Collaborator

@jkriege2 jkriege2 commented Dec 27, 2016 •
edited
Loading

@SchrodingersGat
Copy link
Contributor

Great work here - just a couple of things:

Duplicate Items

There are some duplicate footprints e.g.
Pin_Header_Straight_2x40_Pitch2.00mm

and

Pin_Header_Straight_2x40_Pitch2.0mm

Please delete the old footprints, and ensure that the new ones say _Pitch2.00mm (i.e. retain two decimal places to match others)

Default Pitch

Now that there are many, many items in this library, I would suggest adding the explicit _Pitch2.54mm to the name(s) of the appropriate headers, rather than leaving them assumed.

@SchrodingersGat SchrodingersGat mentioned this pull request Dec 27, 2016
Closed
@SchrodingersGat
Copy link
Contributor

Please delete duplicate items also :) ( _Pitch2.0mm )

@jkriege2 jkriege2 mentioned this pull request Dec 27, 2016
Merged
@jkriege2
Copy link
Collaborator Author

Hi!
OK, done. Please also merge KiCad/kicad-library#865 so the 3D models are renamed!

Best,
JAN

PS: Thanks for the review!

@SchrodingersGat
Copy link
Contributor

Fantastic work :)

@SchrodingersGat SchrodingersGat merged commit 9ae7778 into KiCad:master Dec 27, 2016
@jkriege2 jkriege2 mentioned this pull request Jun 4, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkriege2 @SchrodingersGat