Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

make QFP rectangle #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make QFP rectangle #8

wants to merge 1 commit into from

Conversation

bigrom26
Copy link

@bigrom26 bigrom26 commented Apr 27, 2020

Replace this line with your commit message! Please provide a description of your pull request


Thanks for creating a pull request to contribute to the KiCad footprint wizards! To speed up integration of your PR, please check the following items:

  • Provide a description for your PR (are you creating a new wizard or improving an existing one?)
  • Include a screenshot of the wizard screen with an example created footprint

@nickoe
Copy link

nickoe commented May 1, 2020

Please follow the issue template.

@bigrom26
Copy link
Author

bigrom26 commented May 1, 2020

This is an upgrade of the existing QFP square wizard.
QFP rectangle screen

Copy link
Collaborator

@sethhillbrand sethhillbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally good. The only comments are inconsistencies in the formatting. We don't have a fixed Python style but we do need to be consistent within the file.

array = PA.PadLineArray(v_pad, pads_per_row, pad_pitch, False, pin1Pos)
array.SetFirstPadInArray(pads_per_row + 1)
array = PA.PadLineArray(v_pad, pads_per_col, pad_pitch, False, pin1Pos)
array.SetFirstPadInArray( pads_per_row + 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to stay consistent in spacing

array.AddPadsToModule(self.draw)

#right row
pin1Pos = pcbnew.wxPoint(h_pitch / 2, 0)
array = PA.PadLineArray(h_pad, pads_per_row, -pad_pitch, True,
pin1Pos)
array.SetFirstPadInArray(2*pads_per_row + 1)
array.SetFirstPadInArray( pads_per_row + pads_per_col + 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space at start

pin1Pos)
array.SetFirstPadInArray(3*pads_per_row + 1)
array.SetFirstPadInArray( 2*pads_per_row + pads_per_col + 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space at start and missing spaces around '*'.

sizex = (right_edge + cmargin) * 2
sizey = (bottom_edge + cmargin) * 2
self.draw.SetLayer( pcbnew.F_CrtYd )
sizex = ( right_edge + cmargin ) * 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add extra spaces here unless you are going to be consistent with them through the file.

@sethhillbrand
Copy link
Collaborator

ping @bigrom26

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants