Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Relay: Added Finder 36.11 footprints (copied from Sanyou relays). #1181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgottschlag
Copy link

The shape is identical, but the pins are numbered differently.

The footprint checker complains about some rules, but (except for F7.2) the original Sanyou relay footprint violates the same rules. I kept the footprint identical for consistency.

Due to the different pin names, the footprint checker also complains about pin A1 not being at the center. Should the symbol be moved? I kept the offset identical for now for better exchangeability with the Sanyou footprint.


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
    https://www.finder-relais.net/en/finder-relays-series-36.pdf

  • An example screenshot image is very helpful
    2018-12-18-090510_662x561_scrot
    2018-12-18-090600_683x582_scrot

  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
    (no 3d models yet)

  • Check the output of the Travis automated check scripts - fix any errors as required

The shape is identical, but the pins are numbered differently.
@CLAassistant
Copy link

CLAassistant commented Dec 18, 2018

CLA assistant check
All committers have signed the CLA.

@poeschlr poeschlr added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Dec 18, 2018
@poeschlr poeschlr removed the Pending reviewer A pull request waiting for a reviewer label Jan 19, 2019
@poeschlr poeschlr self-assigned this Jan 19, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Jan 19, 2019

Could you change the pad shape of A1 to be square or rounded rectangle to differentiate it from all others making debugging easier?
Plus add pin 1 markers pointing to that pin.

Some of the dimensions are also quite wrong.
releay svg


Additionally move the footprint such that A1 is at the origin. And rotate it by 90 degree clockwise such that that pin results nearest the top left corner.

@poeschlr poeschlr added the Abandoned Original author has stopped working on the PR label Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new footprint to library Pending changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants