Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Stocko fix #1430

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Stocko fix #1430

merged 1 commit into from
Mar 7, 2019

Conversation

balcer
Copy link
Contributor

@balcer balcer commented Feb 23, 2019

During 3D model generation I noted that I broke footprints.

stocko

https://www.stocko-contact.com/downloads/steckverbindersystem-raster-2,5-mm.pdf#page=15


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@myfreescalewebpage
Copy link
Collaborator

@balcer many files changed here, is it really wanted ? Please have a look at the git diff, thanks!

@evanshultz
Copy link
Collaborator

The CONNFLY USB connector is probably an accident. All other changes files are Stocko MKS parts. Note that I didn't check each one, just quickly looked at changed files.

pointhi/kicad-footprint-generator#298 is the PR for the script fix that drove this, so these are generated by script, which is why some footprints only had the time stamp changed.

@myfreescalewebpage
Copy link
Collaborator

The CONNFLY USB connector is probably an accident

Yes I think too

@myfreescalewebpage myfreescalewebpage added Enhancement Improves existing footprint in the library Pending reviewer A pull request waiting for a reviewer labels Feb 25, 2019
@balcer
Copy link
Contributor Author

balcer commented Mar 4, 2019

Now should be ok. sorry for problems

@evanshultz evanshultz self-assigned this Mar 5, 2019
@evanshultz
Copy link
Collaborator

evanshultz commented Mar 7, 2019

I just quickly checked the script fix and it did add the -X offset at 3.6mm from pin 1, which is the correct dimension in the datasheet. I added more notes at the script PR that don't affect the footprint.

Looking at the code paths, and even though they were submitted and checked at #1403, I dimensioned both 2-pin, the 3-pin, and the highest pin count footprints:
image

@evanshultz evanshultz merged commit 0890365 into KiCad:master Mar 7, 2019
@balcer
Copy link
Contributor Author

balcer commented Mar 7, 2019

thx

@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Apr 1, 2019
DaToBSn pushed a commit to DaToBSn/kicad-footprints that referenced this pull request Jul 2, 2019
* 'master' of github.com:KiCad/kicad-footprints:
  Fix Tensility 54-00023 (KiCad#1467)
  fix dimension (KiCad#1430)
  Update referenced docs
  Add separate paste pads, fix courtyard
  Package SO: Create Linear MSOP-12-16 3x4mm (KiCad#1457)
  Fix up footprint for TUSB730
  Use parent FP zone connection on rect pads (KiCad#1440)
  Package_SO: Add a new HTSSOP-20-1EP_4.4x6.5mm_P0.65mm_EP3.4x6.5mm_Mas… (KiCad#1441)
  Add Myrra EF20 footprint (KiCad#1436)
  Fix courtyard dimensions (were 0.3mm offset)
  Update Linear_DE14MA.kicad_mod
  Transform jumpers into graphical polygons (KiCad#1437)
  add Analog CP-16-22 LFCSP-16-1EP footprint (KiCad#1353)
  Remove copper layer from paste (stencil) pads
  Update Infineon MLPQ-48
  Add reverse mount 18.4x8mm TSOP-I-32 (KiCad#1421)
  Add 9 mm Alpha vertical pots (KiCad#1388)
  Create Infineon_MLPQ-48-1EP_7x7mm_P0.5mm_EP5.55x5.55mm.kicad_mod
  Rotated 90 degree
  Added Beagleboard pocket beagle foot print
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing footprint in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants