-
Notifications
You must be signed in to change notification settings - Fork 713
Conversation
For reference this is the script pull request: pointhi/kicad-footprint-generator#169 Also this part is on page 15 of the linked document. Please modify the datasheet link to include this by adding the suffix I would suggest to use oval pads that are thinner in x direction than the circle is now. You could even decrease the width by 0.5mm and still have 0.25mm copper left. (And result in 1mm clearance which would really be more than enough.) The courtyard clearance is still not right. (Remember it is relative to the body size -> The fab layer represents the body size so the courtyard is relative to the Fab layer. Silk is ignored by it.) There are a few dimensions not given in the datahseet. (Not a big deal) but do you have a source for them?) I marked them orange in the drawing. |
Hi, @poeschlr I added information about page (it is 13, not 15). Pins now are oval. Courtyard clearance corrected. Sorry, I forgot to change this in my script. I measured orange dimensions on the real component now they are correct. I will also check this after my board will be manufactured and make the correction if needed. Next time I will try to use more helpers from your script. This was my first attempt so I started with example script from generator. More exaples would make it easer. No I move to 3D scripting. |
The pin 1 would also need the same y dimension as the oval pads (elongated pad instead of square) If you use the array node instead of generating all pads manually (in a for loop) yourself then this should happen automatically (The array replaces pad 1 with rectangle or maybe even rounded rectangle depending on settings.): https://github.com/pointhi/kicad-footprint-generator/blob/30841f4e2b95f3df421f754d05d2287c490f2695/scripts/Connector/Connector_JST/conn_jst_xh_tht_top.py#L128-L138 Regarding examples: Well i would have assumed people copy the generator of a similar accepted part in preference to starting from simplified examples. (We could maybe add a note in the example directory that the script directory holds better examples if one plans to implement something that is in any way similar to existing generators.) |
@poeschlr Hope, now it is ready for merge. :) |
Looks good, thanks |
* 'master' of github.com:KiCad/kicad-footprints: (24 commits) Scripted sop-4 and sop-18 footpritns (KiCad#1386) Scripted version of MSOP-16 footprints (KiCad#1380) Scripted versions of MSOP-12 footprints (KiCad#1379) Scripted MSOP-10 ep for LT3757EMSE and LTC3805xMSE (KiCad#1378) Scripted version of SOP-4 footprint for isolators (KiCad#1385) Scripted UQFN footprints (KiCad#1398) Scripted MSOP-10 EP for A4952_LY (KiCad#1377) Scripted version of wqfn footprints (KiCad#1399) Scripted UQFN-20 ep1.85 plus correciton for symbol (KiCad#1397) Add LED-APA102-2020 (KiCad#1389) Added data sheet links to a number of fuse foot prints and renamed one fuse foot print (KiCad#1295) Add TRAPC5M 5-Pin Mini-XLR Connector (KiCad#1393) Add Stocko_MKS_16XX Connectors (KiCad#1403) Button_Switch_SMD: Add KSC7 button from CK switches (KiCad#755) OptoDevice: Add APDS-9306-065 (KiCad#1196) Connector_Audio: Add Jack_3.5mm_CUI_SJ-3523-SMT_Horizontal/Jack_3.5mm_CUI_SJ-3524-SMT_Horizontal (KiCad#1173) add keepout Add Raspberry Pi Zero footprint using Through-hole pin socket (KiCad#1066) add reviewer suggestions fix unintendent files changes ...
This is reopened #912. Fixed all reviewer suggestions.
Datasheet: https://www.stocko-contact.com/downloads/steckverbindersystem-raster-2,5-mm.pdf
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: