Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add SKY65605-21 #1522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add SKY65605-21 #1522

wants to merge 1 commit into from

Conversation

pbn4
Copy link

@pbn4 pbn4 commented Apr 3, 2019

Add SKY65605-21


URL: http://www.skyworksinc.com/uploads/documents/SKY65605_21_203118F.pdf (page 6)

2019-04-03-090919_1507x500_scrot

I have run check_kicad_mod.py but I don't know what to do with the output:

Traceback (most recent call last):
  File "check_kicad_mod.py", line 117, in <module>
    rule.check()
  File "/home/michal/kicad-library-utils/pcb/rules/G1_7.py", line 17, in check
    if 'linux' in platform.platform().lower() and not checkLineEndings(self.module.filename):
  File "/home/michal/kicad-library-utils/common/rulebase.py", line 75, in checkLineEndings
    LE1 = ord(chr(filecontentsraw[-2]))
TypeError: an integer is required

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2019

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Apr 3, 2019
@evanshultz evanshultz self-assigned this Apr 5, 2019
@evanshultz evanshultz closed this Apr 5, 2019
@evanshultz evanshultz reopened this Apr 5, 2019
@evanshultz
Copy link
Collaborator

Thanks for contributing and welcome!

Before we can move forward we need for you to please sign the CLA. Let us know if you have any problems getting that done.

That error you posted above is a problem with our CI which should hopefully be resolved by closing and re-opening. Hang on...

@evanshultz
Copy link
Collaborator

How did you make this footprint? I don't see a recommended one in the datasheet. Is there another document you used to generate it? Or, just guessing because of the round rect pads, did you use our LGA footprint generator?

@pbn4
Copy link
Author

pbn4 commented Apr 5, 2019

When I get to the CLA site it says I already signed.

How did you make this footprint? I don't see a recommended one in the datasheet. Is there another document you used to generate it? Or, just guessing because of the round rect pads, did you use our LGA footprint generator?

Right, there is no recommended footprint for this one, I did it by analogy to SKY65504 pull request, including comments.

@evanshultz
Copy link
Collaborator

The part in the PR you reference has a recommended footprint in that datasheet. This part, unless I've missed it, does not have a recommended footprint.

And there is insufficient info in the datasheet to use our IPC-compliant scripts to make a footprint.

So... how do you want to proceed? Perhaps asking Skyworks?

@evanshultz evanshultz closed this Apr 5, 2019
@evanshultz evanshultz reopened this Apr 5, 2019
@pbn4
Copy link
Author

pbn4 commented Apr 6, 2019

I asked them to provide recommended footprint just now. I'll report back the progress.

@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Apr 9, 2019
@pbn4
Copy link
Author

pbn4 commented Apr 15, 2019

@evanshultz I got response from Skyworks:

image001

I applied the changes just now.

@pbn4
Copy link
Author

pbn4 commented Apr 15, 2019

2019-04-15-214111_1920x1200_scrot

@pbn4
Copy link
Author

pbn4 commented Apr 17, 2019

Now I noticed that pin 1 silkscreen designation is on the wrong side, right?

@evanshultz
Copy link
Collaborator

It looks OK to me. Can you point out the issue you're seeing?

Please shrink the fab layer ref des so it fits within the body.

@pbn4
Copy link
Author

pbn4 commented May 11, 2019

2019-05-11-151746_1366x768_scrot

@pbn4
Copy link
Author

pbn4 commented May 11, 2019

Travis complains about shrinking the ref.

@evanshultz
Copy link
Collaborator

@pbn4
Are you still around? If we can wrap this up quickly it can be merged before all PRs are closed due to moving to GitLab. We don't have much time.

Because this part is so small. https://kicad-pcb.org/libraries/klc/F5.2/ says that 0.5mm - 1mm are allowed, and this one is 0.4mm and still far too big for the part. That being said, here is the 0402 capacitor footprint and it's much smaller:
image

So go ahead and squash the fab ref des down a bit more.

And please let me know the pin1 issue you noted above. I'm not getting it.

Lastly, there is an issue Travis caught with the 3D model name. Please correct that.

@evanshultz evanshultz mentioned this pull request Oct 1, 2020
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants