Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Lumex SML-LX0404SIUPGUSB #1698

Merged
merged 1 commit into from Oct 1, 2020

Conversation

jordiorlando
Copy link
Contributor

@jordiorlando jordiorlando commented Jul 14, 2019

Add Lumex SML-LX0404SIUPGUSB (big sibling to #1990)

Datasheet

LED_Lumex_SML-LX0404SIUPGUSB


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Jul 15, 2019
@cpresser
Copy link
Contributor

Hi,
it looks like the silkscreen between the pads might violate KLC F5.1 (0.2mm clearance silk to pad)
Did you try to fit the F.Fab refdes into the body?

@poeschlr
Copy link
Collaborator

We allow smaller silk clearances for small parts like these. (The lowest allowable is clearance equal to line width.)

@jordiorlando
Copy link
Contributor Author

@cpresser it's a bit smaller bc otherwise basically no silkscreen would fit. And yeah the refdes really has no hope of fitting inside the outline.

@evanshultz evanshultz self-assigned this Aug 6, 2019
@evanshultz
Copy link
Collaborator

  1. Add the official datasheet at https://www.lumex.com/spec/SML-LX0404SIUPGUSB.pdf to the description.
  2. The courtyard is too small. It should be a 0.9mm square.
  3. No silk will fit between pads. Pads 1 and 2 are 0.4mm apart. 0.12mm clearance requires a line end 0.18mm away to account for the line endcap. That means a line length of 0.04mm. No way.
  4. Similarly, the pin 1 silk lines need to be 0.83mm away from the origin and they are only 0.8mm now.

@poeschlr
Why is text limited to 0.5mm and not smaller? If the assy layer is printed to PDF, and I'm not sure what else it's used for, vector text can be zoomed without a problem. If printed on paper, even 0.5mm could be a problem.

@jordiorlando
Copy link
Contributor Author

jordiorlando commented Nov 24, 2019

@evanshultz fixed all 4 points

LED_Lumex_SML-LX0404SIUPGUSB

@jordiorlando jordiorlando mentioned this pull request Dec 5, 2019
5 tasks
@jordiorlando jordiorlando force-pushed the Lumex_SML-LX0404SIUPGUSB branch 2 times, most recently from a2679b7 to 129c8fe Compare March 14, 2020 19:41
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Mar 24, 2020
@evanshultz
Copy link
Collaborator

The silk is at 0.825 instead of 0.83 as it should be. Practically, that won't make any difference.

And as I found at #1522 (comment), fab ref des are smaller on some parts. But this is OK with me.

@evanshultz evanshultz merged commit 75f776d into KiCad:master Oct 1, 2020
@jordiorlando jordiorlando deleted the Lumex_SML-LX0404SIUPGUSB branch October 2, 2020 00:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants