Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix EP round radius for QFN footprints #1913

Merged
merged 3 commits into from
Jan 13, 2020
Merged

Conversation

poeschlr
Copy link
Collaborator

Splitting #1821 into smaller bits. This one handles "normal" QFN footprints with the new EP radius. (I think one or two non EP footprints are also included)
Script: pointhi/kicad-footprint-generator#422
Issue: #1798

For some strange reason the following footprint is generated but does not exist in the lib:

  • QFN-14-1EP_1.6x1.6mm_P0.4mm_EP0.74x0.74mm_ThermalVias.kicad_mod

@poeschlr poeschlr added Bug Fix footprint existing in the library Pending reviewer A pull request waiting for a reviewer labels Oct 10, 2019
@poeschlr poeschlr added this to the 5.1.5 milestone Oct 10, 2019
@evanshultz
Copy link
Collaborator

@poeschlr
I don't find QFN-14-1EP_1.6x1.6mm_P0.4mm_EP0.74x0.74mm_ThermalVias.kicad_mod used by any symbol now. But I think I figured it out:

So I think we need this footprint. However, some work may need to be done:

  • The symbol PR may need to be updated to match the footprint name.
  • The size definition in the YAML file could be corrected.
  • You may want to remove or rename the Skyworks footprint from the PR above since it doesn't conform to the typical manufacturer-specific footprint name convention.

@evanshultz
Copy link
Collaborator

The following footprints have minor copper changes:

  • QFN-12-1EP_3x3mm_P0.51mm_EP1.45x1.45mm
  • QFN-24-1EP_4x4mm_P0.5mm_EP2.65x2.65mm
  • QFN-38-1EP_4x6mm_P0.4mm_EP2.65x4.65mm

QFN-32-1EP_7x7mm_P0.65mm_EP5.4x5.4mm_ThermalVias oddly has the location of the thermal vias changed but I think that's OK too.

Should the script be updated to add a suffix if the corner pads are beveled?

Here are other footprints for TI parts which don't have rounded corners even though the footprint drawings shows it:

  • QFN-20-1EP_3.5x3.5mm_P0.5mm_EP2x2mm (no footprint given in the doc provided, but it's used by bq25570 and one is given at http://www.ti.com/lit/ds/symlink/bq25570.pdf)
  • QFN-56-1EP_8x8mm_P0.5mm_EP4.5x5.2mm (no footprint given so it's actually OK)
  • QFN-56-1EP_8x8mm_P0.5mm_EP5.6x5.6mm
  • QFN-64-1EP_9x9mm_P0.5mm_EP6x6mm (also missing a link to page 42 of the datasheet)

@poeschlr
Copy link
Collaborator Author

poeschlr commented Jan 5, 2020

The skyworks footprint stuff is fixed in #2035 and KiCad/kicad-symbols#2423

@evanshultz
Copy link
Collaborator

Thanks!

That leaves two things from #1913 (comment):

  1. Do you want to add a suffix if corner pads are beveled? I guess no, just asking anyway.
  2. Can you add the direct page link to the URL of the footprint missing one?

@poeschlr
Copy link
Collaborator Author

Doclink updated

Do you want to add a suffix if corner pads are beveled? I guess no, just asking anyway.

Not for now. We might want to look into this at a later point. (The script luckily knows which footprints have corner pads so it is easy to add such a suffix later on.)

@evanshultz evanshultz merged commit a086833 into KiCad:master Jan 13, 2020
@evanshultz
Copy link
Collaborator

Thanks!

@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Jan 14, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix footprint existing in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants