Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add SKY13575-639LF. #1585

Merged
merged 1 commit into from Dec 19, 2019
Merged

Conversation

matthuszagh
Copy link
Contributor

http://www.skyworksinc.com/uploads/documents/SKY13575_639LF_203270D.pdf

image

Footprint PR: KiCad/kicad-footprints#1443


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@myfreescalewebpage myfreescalewebpage added Pending reviewer A pull request waiting for a reviewer Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging labels Feb 27, 2019
@myfreescalewebpage myfreescalewebpage self-assigned this Mar 1, 2019
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Mar 1, 2019
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Mar 1, 2019

Hi @matthuszagh , thanks for contributing,

A comment I have during my review:

  • Footprint filter will be QFN*1EP*1.6x1.6mm*P0.4mm*

Else no comment, looks good ! Just need to wait this modification and the integration of the footprint.

Cheers,
Joel

@matthuszagh
Copy link
Contributor Author

hi @myfreescalewebpage i've made the change since the footprint has now been merged. it seems like this made changes to diode too, but i'm confused bc I don't see that in my local git repo....

Also it looks like I need to delete the datasheet?

@evanshultz
Copy link
Collaborator

@matthuszagh
Yes, the datasheet should only be in the DCM file and not the LIB file.

@antoniovazquezblanco
Did you mean to add BAV199DW as a discrete symbol to this PR? Right now BAV199DW is an ALIAS of BAV99S so something seems wrong to me.

@myfreescalewebpage myfreescalewebpage removed the Pending footprint Pending footprint acceptance before merging label Sep 21, 2019
@myfreescalewebpage
Copy link
Collaborator

@matthuszagh yes please, as confirmed by @evanshultz too. Take care, it should be empty in DCM file, not in the LIB file.

@antoniovazquezblanco I don't understand your commits too. Please check.

@antoniovazquezblanco
Copy link
Collaborator

I did not push anything here. Those commits have been merged in #1575.

It seems that there has been some trouble with this pull request branch but I do not know what has happened.

@matthuszagh
Copy link
Contributor Author

What's the best way to go forward here? Make the changes above and then rebase on the current master?

@myfreescalewebpage
Copy link
Collaborator

Close and open to refresh Travis result (button not available in Travis, don't know why...)

@myfreescalewebpage
Copy link
Collaborator

Hi @matthuszagh and sorry for the delay.
One error remaining in Travis : Datasheet field should be empty in the lib file.
I don't know if it is possible to fix it in the last version of KiCad.... Else can you do it with a test editor please ? This is "F3" field. You can look at the other devices too.
Joel

@matthuszagh
Copy link
Contributor Author

@myfreescalewebpage I've removed the datasheet field. Let me know if this is correct.

@myfreescalewebpage
Copy link
Collaborator

@matthuszagh you have a modification of BAV199DW (see https://github.com/KiCad/kicad-symbols/pull/1585/files) which is not expected. To be fixed before we can merge.

@matthuszagh
Copy link
Contributor Author

Alright, I've rebased onto master. Sorry for the force push... I'm not really sure how those commits are making it in there. Anyway, hopefully this fixes the issue. Let me know.

@myfreescalewebpage
Copy link
Collaborator

Thanks, no worries for the force push.
Something is strange, the device is twice in the dcm file. See https://github.com/KiCad/kicad-symbols/pull/1585/files. To be fixed manually I think.

@matthuszagh
Copy link
Contributor Author

How's this?

@myfreescalewebpage
Copy link
Collaborator

Ok, better to open it.
Can you update the datasheet link ? Seems now "https://www.skyworksinc.com/-/media/SkyWorks/Documents/Products/2201-2300/SKY13575_639LF_203270D.pdf".
No other comment.

@matthuszagh
Copy link
Contributor Author

Updated.

@myfreescalewebpage
Copy link
Collaborator

Perfect, thanks for the quick fix! Merging.

@myfreescalewebpage myfreescalewebpage merged commit 486f939 into KiCad:master Dec 19, 2019
@matthuszagh matthuszagh deleted the SKY13575-639LF_New branch December 19, 2019 21:33
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Dec 23, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Jan 5, 2020

Why does this symbol point to the normal qfn package instead of the special manufacturer specific version in the RF.pretty lib? RF.pretty/Skyworks_SKY13575_639LF

Edit to clarify: The package is not really a qfn as its "leads" are not shaped like in a normal qfn. Additionally this is a high frequency part so the pad sizes might be important.

Fixed in #2423

@matthuszagh
Copy link
Contributor Author

@poeschlr hm no idea why I didn't use my own footprint I made for this... Anyway thanks for fixing!

jamesrlucas pushed a commit to jamesrlucas/kicad-symbols that referenced this pull request Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants