Add SKY13575-639LF. #1585
Add SKY13575-639LF. #1585
Conversation
Hi @matthuszagh , thanks for contributing, A comment I have during my review:
Else no comment, looks good ! Just need to wait this modification and the integration of the footprint. Cheers, |
hi @myfreescalewebpage i've made the change since the footprint has now been merged. it seems like this made changes to diode too, but i'm confused bc I don't see that in my local git repo.... Also it looks like I need to delete the datasheet? |
@matthuszagh @antoniovazquezblanco |
@matthuszagh yes please, as confirmed by @evanshultz too. Take care, it should be empty in DCM file, not in the LIB file. @antoniovazquezblanco I don't understand your commits too. Please check. |
I did not push anything here. Those commits have been merged in #1575. It seems that there has been some trouble with this pull request branch but I do not know what has happened. |
What's the best way to go forward here? Make the changes above and then rebase on the current master? |
Close and open to refresh Travis result (button not available in Travis, don't know why...) |
Hi @matthuszagh and sorry for the delay. |
@myfreescalewebpage I've removed the datasheet field. Let me know if this is correct. |
@matthuszagh you have a modification of BAV199DW (see https://github.com/KiCad/kicad-symbols/pull/1585/files) which is not expected. To be fixed before we can merge. |
ec382eb
to
58e9830
Compare
Alright, I've rebased onto master. Sorry for the force push... I'm not really sure how those commits are making it in there. Anyway, hopefully this fixes the issue. Let me know. |
Thanks, no worries for the force push. |
58e9830
to
fe734c0
Compare
How's this? |
Ok, better to open it. |
fe734c0
to
288a42d
Compare
Updated. |
Perfect, thanks for the quick fix! Merging. |
Why does this symbol point to the normal qfn package instead of the special manufacturer specific version in the RF.pretty lib? RF.pretty/Skyworks_SKY13575_639LF Edit to clarify: The package is not really a qfn as its "leads" are not shaped like in a normal qfn. Additionally this is a high frequency part so the pad sizes might be important. Fixed in #2423 |
@poeschlr hm no idea why I didn't use my own footprint I made for this... Anyway thanks for fixing! |
http://www.skyworksinc.com/uploads/documents/SKY13575_639LF_203270D.pdf
Footprint PR: KiCad/kicad-footprints#1443
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: