Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

added Alps EC11 and EC12 rotary encoder footprints #288

Merged
merged 5 commits into from
May 8, 2018

Conversation

jkriege2
Copy link
Collaborator

@jkriege2 jkriege2 commented Jan 21, 2018

2018-01-21 21_39_36-pcbnew d__kicad_devproject_devproject kicad_pcb
2018-01-21 21_39_24-pcbnew d__kicad_devproject_devproject kicad_pcb
2018-01-21 21_39_48-3d viewer

check against 3D models from ALPS: EC11

These images show that the ALPS models fit the footprints:
2018-01-22 19_41_26-3d viewer
2018-01-22 19_41_12-3d viewer
2018-01-22 19_40_20-3d viewer
2018-01-22 19_39_53-3d viewer

check against 3D models from ALPS: EC12

These images show that the ALPS models fit the footprints:
2018-01-22 19_46_43-3d viewer
2018-01-22 19_45_52-3d viewer
2018-01-22 19_45_43-3d viewer


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • Check the output of the Travis automated check scripts - fix any errors as required

@poeschlr
Copy link
Collaborator

poeschlr commented Feb 2, 2018

Take a closer look at the silk outlines. Some of them are "behind" the fab outline instead of being outside of it.
From the 3d models it looks like the pads that currently have number 0 are there to increase the mechanical strength. So i think these should get pin number "MP" as decided in issue #117

The landing patterns look ok.

@jkriege2
Copy link
Collaborator Author

jkriege2 commented Feb 2, 2018

I fixed the silkscreen-problems (only found two in the EC11E's).

ABout the pin-naming, @evanshultz raised comparable question at the PR for the symbols: KiCad/kicad-symbols#220 ... I think we should discuss that there and I will change both PRs, depending on the outcome of that discussion.

@jkriege2
Copy link
Collaborator Author

jkriege2 commented Feb 7, 2018

rename pin 0 to pin MP as explained over in KiCad/kicad-symbols#220

@jkriege2 jkriege2 mentioned this pull request Feb 14, 2018
4 tasks
@jkriege2
Copy link
Collaborator Author

@poeschlr @evanshultz Since the symbols have been merged with KiCad/kicad-symbols#220 ... Could I get a review for these?

Thanks,
JAN

@poeschlr
Copy link
Collaborator

poeschlr commented May 8, 2018

Sorry this has been forgotten for so long. Looks good now. Thanks

@poeschlr poeschlr merged commit 9e65ca8 into KiCad:master May 8, 2018
@myfreescalewebpage myfreescalewebpage added the Addition Adds new footprint to library label May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants