Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

Added BAS40-04, AD8591, AD8592, and AD8594 #1858

Closed
wants to merge 10 commits into from
Closed

Conversation

FJRocha
Copy link

@FJRocha FJRocha commented Nov 25, 2017

Added BAS40-04 to the diode library, and AD8591, AD8592, and AD8594 to the "analog-devices" library.

@Misca1234
Copy link
Collaborator

Hi

When adding symbols it is beneficial if you push some screen shoots as well, like in this push

#1712

Added "Dual" to description
@FJRocha
Copy link
Author

FJRocha commented Nov 27, 2017

image

@FJRocha
Copy link
Author

FJRocha commented Nov 27, 2017

image

@FJRocha
Copy link
Author

FJRocha commented Nov 27, 2017

I think the library updates are ok, but I can't make them pass the Travis-ci check.

Does anyone know why this error keeps coming up in the Travis-ci check?:
if line[0] in self._KEYS:
IndexError: list index out of range

@FJRocha
Copy link
Author

FJRocha commented Nov 27, 2017

Closing this pull request to separate the pull requests of Diode from the Analog Devices libraries.

@FJRocha FJRocha closed this Nov 27, 2017
@FJRocha
Copy link
Author

FJRocha commented Nov 27, 2017

OK, I couldn't figure out how to split the pull request, so here I try again.

@FJRocha FJRocha reopened this Nov 27, 2017
@jkriege2
Copy link
Collaborator

@SchrodingersGat could you have a look at the script output?

Thanks,
JAN

changed footprint filter from "*SOT-23-6*" to "*SOT?23?6*"
Fixed location of NC pin 8 on AD8594.
@FJRocha
Copy link
Author

FJRocha commented Nov 27, 2017

image

@evanshultz
Copy link
Collaborator

Opamps and comparators should go into linear.lib. Please make that change and then I will review.

Moved DA8591, AD8592, and AD8594 from "analog_devices.lib" to "linera.lib"
@FJRocha FJRocha closed this Nov 30, 2017
@FJRocha FJRocha reopened this Nov 30, 2017
@FJRocha
Copy link
Author

FJRocha commented Dec 1, 2017

@evanshultz, Moved the OpAmps to "liner.lib". All checks passed. ;-)

@poeschlr
Copy link
Collaborator

The linear lib will be transferred over to the new repo with PR KiCad/kicad-symbols#116.

This means we can no longer accept this contribution in the legacy repo. So please re open this in the new repo https://github.com/KiCad/kicad-symbols.
I think they need to be moved into Amplifier_Operational.lib

Sorry for the inconvenience.

@SchrodingersGat
Copy link
Contributor

As we are now close to moving all the symbols to the new kicad-symbols repository, this PR will have to be reissued at https://github.com/kicad/kicad-symbols

Thanks for your contributions, and sorry for the inconvenience

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants