Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Hdsp led #276

Merged
merged 4 commits into from Oct 22, 2018
Merged

Hdsp led #276

merged 4 commits into from Oct 22, 2018

Conversation

Misca1234
Copy link
Collaborator

@Misca1234 Misca1234 commented Mar 4, 2018

This is the complementary push of the HDSP 7 segments display as mentioned in
KiCad/kicad-symbols#311

HDSP-A401
HDSP-A151 alias HDSP-7501
HDSP-7401
HDSP-7801
HDSP-A403
HDSP-A153 alias HDSP-7503
HDSP-7403
HDSP-7803
HDSP-7507
HDSP-7807
HDSP-7508
HDSP-7808

https://docs.broadcom.com/docs/AV02-2553EN

Symbol push
KiCad/kicad-symbols#346

foot print push
KiCad/kicad-footprints#403

3D model push
#276

3D model source push
KiCad/kicad-packages3D-source#109

bild

bild

@Misca1234
Copy link
Collaborator Author

someone should merge this one

@Shackmeister
Copy link
Collaborator

hi @Misca1234 as far as I can see, these models are not correctly fused. can you please look into that?

@Misca1234
Copy link
Collaborator Author

How can they be incorrectly fused ?

Correct FreeCad tool used
Correct plugin used
Pressed available icons
Copied step and wrl files unmodified

@Shackmeister
Copy link
Collaborator

this is what I get when opening the step files
hdsp

@easyw
Copy link
Contributor

easyw commented May 4, 2018

@Misca1234
sometimes FC makes an union of parts internally, but when exported as 'step' they explode to many...
This is tipycally due to an OCC issue with coplanar faces.. a trick that most solves is to slightly make your parts have a common volume instead of a tangent surface

@Misca1234
Copy link
Collaborator Author

If you click on the other "legs" you can see that they are different distinct part of the model, for example, Leg001_sp011 is the dot
Leg001_sp015 is the lower left segment

Do you want me to try to create a .step file with the original names in it ?

@easyw
Copy link
Contributor

easyw commented May 7, 2018

@Misca1234
you need to fuse all the parts to make a single unioned STEP file
HDSP-7507_7807_fused.FCStd.zip

@Misca1234
Copy link
Collaborator Author

Now, tell in which step of these two where it is possible to make them single union step file more than using the buttons in the macro

bild

bild

@easyw
Copy link
Contributor

easyw commented May 7, 2018

the sequence you did should be good... but the result may depends also on your FC version and OCC version you used...
From your STEP file you should have a Open CASCADE STEP processor 7.1, which means you shouldn't be on the latest stable release:
Version: 0.17.13519 with OCC version: 7.2.0 (those latest 7.2 have some improvements in unioning co-planar surfaces)
PS remember to rename the unioned object as the STEP file name.
PPS (EDIT) I tried also with an old release with OCC7.1 but I can make a union that remains unioned also after been exported...

@Misca1234
Copy link
Collaborator Author

Let me try Freecad version 0.17 11223

@easyw
Copy link
Contributor

easyw commented May 8, 2018

Let me try Freecad version 0.17 11223

this is very outdated... now there are a bunch of new commits
https://github.com/FreeCAD/FreeCAD/releases

  • developing 0.18:
    ** FreeCAD_0.18.13666_x64_dev_win.7z
    ** FreeCAD_0.18.13666.glibc2.17-x86_64.AppImage
    ** FreeCAD_0.18-13651.4604bd9-OSX-x86_64-Qt5.dmg
  • stable 0.17:
    ** FreeCAD-0.17.13519.1a8b868-WIN-x64-portable.7z
    ** FreeCAD-13519.glibc2.17-x86_64.AppImage
    ** FreeCAD_0.17-13519.1a8b868-OSX-x86_64-Qt5.dmg

@Misca1234
Copy link
Collaborator Author

I know, but i was told last autumn to use this release becosue of a bug in later releases in the step export code.

I have remade the models now

@Misca1234
Copy link
Collaborator Author

Misca1234 commented May 8, 2018

by the way, I did a git push to the upstream instead of the origin, which means the main master do have an invalid branch, is possible to delete the other one ?

@easyw
Copy link
Contributor

easyw commented May 8, 2018

If you stay on stable 0.17 13519 you will be fine now

@Misca1234
Copy link
Collaborator Author

poke

@Shackmeister
Copy link
Collaborator

Hi @Misca1234 it appears like all the step files are called "Fusion_sp" inside the file

@Misca1234
Copy link
Collaborator Author

Oh, that old problem, let me fix it

@Misca1234
Copy link
Collaborator Author

I can see that a lot of my old .step files already in the library have that problem but none of those in this push ?

I can make a separate push to fix it inside the ones that already have been merged.

@Misca1234
Copy link
Collaborator Author

@Shackmeister
None if the step files is called Fusion_sp inside or you could perhaps elaborate of what you mean ?

@Misca1234
Copy link
Collaborator Author

@Shackmeister
None if the step files is called Fusion_sp inside or you could perhaps elaborate of what you mean ?

1 similar comment
@Misca1234
Copy link
Collaborator Author

@Shackmeister
None if the step files is called Fusion_sp inside or you could perhaps elaborate of what you mean ?

@Shackmeister
Copy link
Collaborator

looks nice :) thanks for the contribution :)

@Misca1234
Copy link
Collaborator Author

@Shackmeister
Man, merge it ^^

@Shackmeister Shackmeister merged commit dd3a004 into KiCad:master Oct 22, 2018
@Shackmeister
Copy link
Collaborator

Tried yesterday but it didnt work :P

@Misca1234
Copy link
Collaborator Author

Github got some problems for 18 hours ago and was not solved for 12 hours ago so I guess it was that who prevented the merge

@Misca1234 Misca1234 deleted the HDSP_LED branch October 22, 2018 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants