Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add new Recom part RAC04-xxSGx #407

Merged
merged 2 commits into from
Sep 27, 2018
Merged

Add new Recom part RAC04-xxSGx #407

merged 2 commits into from
Sep 27, 2018

Conversation

Cylindric
Copy link
Contributor

@Cylindric Cylindric commented Sep 23, 2018

I am adding a RECOM AC/DC converter symbol, footprint and model.

RAC04-GA Datasheet
also suitable for the
RAC04-GB Datasheet

The model was created using Fusion360, exported to STEP and converted using FreeCAD StepUp tools.

rac04-dimensions

RAC04-GA/B

Symbol PR
Footprint PR
Package PR

  • A screenshot of the model(s) aligned with KiCad footprints is very useful
  • Was the 3D model(s) created in a mechanical modelling program?
  • Source files (or scripts) have been contributed
  • Step model submitted in 1:1 scale
  • WRL model submitted in 1:2.54 scale
  • 3D model alignment checked against KiCad footprint
  • WRL model uses correct material properties
  • Geometry check performed against mechanical models

@Misca1234
Copy link
Collaborator

Do you have the link to 3d model script as well ?

3D model is ok, can be merged with foot print

@Misca1234 Misca1234 added the Pending footprint Pending footprint acceptance before merging label Sep 24, 2018
@Cylindric
Copy link
Contributor Author

I've been looking at the packages3d-source repo, I'll try and add them there. I use Fusion360 to do the actual modelling as I've not been able to get my head around FreeCAD yet, but I should be able to export a useful standalone file from that.

@Misca1234
Copy link
Collaborator

Misca1234 commented Sep 24, 2018

uhm, I do not want to curve you enthusiasm now when you have just started.

Your last model had a cut corner but this one is a "ordinary" block and I have made almost all the converter ACDC and DCDC 3D models based on a script.

If you want to look further into this (that is script generate your 3d model), check repository
https://github.com/easyw/kicad-3d-models-in-freecad

and in directory
https://github.com/easyw/kicad-3d-models-in-freecad/tree/master/cadquery/FCAD_script_generator/Converter_ACDC

With this python script it is dead easy to add new "ACDC blocks",
You add the dimensions of the "block" and feed FreeCad with the script like this

......\freecad\bin\freecad.exe main_generator_Converter_ACDC.py Converter_ACDC_Hahn_HS-400xx_THT

and all needed files will be created, both .step, .wrl and Fcstd files (script based generation does not need to push the .fcstd file)

The step/wrl file is correct merged, right colours and all in good shape for direct merging.

@Cylindric
Copy link
Contributor Author

Always happy to have my enthusiasm curbed if it makes future-me do less 😊

@Cylindric
Copy link
Contributor Author

@Misca1234 just had a play with that script - it's pretty neat. I was using the Converter_ACDC_MeanWell_IRM-03-xx_THT as a template to work out the parameters for my Converter_ACDC_Recom_RAC04-xxSGx_THT, and it appears that they are identical packages.

That raises the question of how to manage that. Should I just create a second identical package for the Recom part? It doesn't seem right to point that footprint at an essentially-unrelated MeanWell part's package. Should they instead be merged into some sort of generic package? But then I don't think there is enough similar packages for that to work either.

It's almost as if the 3D models need aliases like the symbols have :) I'm not opening that can of worms though.

@Misca1234
Copy link
Collaborator

just had a play with that script - it's pretty neat.

Yes, it goes very quickly and all the internal stuff in step and wrl files are correct right away without having deeper knowledge of 3D objects.
it is currently restricted to "simple boxes" but it is possible to add python code for additional forms to create holes etc.

Yes, you are onto something, just compare it to many of the foot prints that is reused between components from many manufactures.

But for now I guess we just create a duplicate of the 3D model, the re use might be a question we should bring up to attention.

PS
There is another script in
https://github.com/pointhi/kicad-footprint-generator/../../..
called "Standardbox, that creates "simple foot prints" of polygon shape
Currently it is only used for
https://github.com/pointhi/kicad-footprint-generator/Battery

If you look into

https://github.com/pointhi/kicad-footprint-generator/Battery/BatteryHolder.py
https://github.com/pointhi/kicad-footprint-generator/Battery/BatteryHolder.yml

you can see how they works, BatteryHolder.py and BatteryHolder.yml can of course be copied and renamed elsewhere.

@Misca1234
Copy link
Collaborator

@Cylindric
Do you still want to merge this or give the script stuff a shoot ?

@Cylindric
Copy link
Contributor Author

Cylindric commented Sep 26, 2018 via email

@Cylindric
Copy link
Contributor Author

I've updated the model with one generated by the script. I'll push the FreeCAD file for that into the -source repo too.

@Misca1234
Copy link
Collaborator

I've updated the model with one generated by the script.

Awesome

I'll push the FreeCAD file for that into the -source repo too.

No, don't do that, only make the push of the scripts (the FreeCAD can always re created from the script)

When pushing script based models, always include the link to the script push as well

@Cylindric
Copy link
Contributor Author

Okay. The scripts are in a third-party repo though, so they won't be reflected in any kicad-* repos.

@Misca1234
Copy link
Collaborator

Misca1234 commented Sep 27, 2018

You mean
https://github.com/easyw/kicad-3d-models-in-freecad

He is well known among the kicad moderators

@Cylindric
Copy link
Contributor Author

Cool. I'm just just forking it now and will submit the config line(s) into that repo later.
I'll close my PR into packages3D-source.

@Cylindric
Copy link
Contributor Author

Okay, I've added the part to easyw/kicad-3d-models-in-freecad#201

@Misca1234
Copy link
Collaborator

Super,
by only looking at the parameter file (main_generator_Converter_ACDC.py) I can review the 3 model if it is correct.

@Misca1234 Misca1234 merged commit c4af942 into KiCad:master Sep 27, 2018
@Cylindric Cylindric deleted the rac04 branch September 27, 2018 20:38
@myfreescalewebpage myfreescalewebpage added Addition Adds new package 3D to library and removed Pending footprint Pending footprint acceptance before merging labels Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new package 3D to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants