Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

create TL3305 series tactile switch models #632

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

andrewzuku
Copy link

@andrewzuku andrewzuku commented Dec 23, 2019

Screenshots and datasheets

I'd like to contribute my 3D models of the TL3305 series tactile switches to match the footprints that already exist in the kicad-footprints repo.

screenshot

Link to matching pull request to kicad-packages3d-source repo.

There are three heights:

Manufacturer supplied 3D model

The manufacturer (E-Switch) supplies STP files behind a form under the "Product configurator" tab here - so they're kinda publicly available.

There's no colour information though, so I reverse-engineered their STP file to create a FreeCAD 0.18 source file, and then re-generated STEP and WRL files using KiCadStepUp.

Potential issues with my models

There are two things I'm not sure about...

1. Internal details

Should I have bothered with internal details? Is this just unnecessary complexity that will slow the 3D viewer down?
Internal details

2. leads below the ground (XY) plane

According to the datasheet, the base of the case sits directly on the PCB, and the leads are shown as 0.1mm below the ground plane. This is also how the manufacturer supplied STP files are positioned, so I've done the same in my FreeCAD part.

leads below the ground (XY) plane

But... looking through the kicad-packages3d-source repo, I see SMD parts with the leads sitting on the ground plane instead (eg: SOT-23W). So what would you prefer?


This is my first ever contribution to KiCad, so thanks in advance for your patience :)

~ Andrew


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items as you complete them:

  • A screenshot of the model(s) aligned with KiCad footprints is very useful
  • Was the 3D model(s) created in a mechanical modelling program?
  • Source files (or scripts) have been contributed
  • Step model submitted in 1:1 scale
  • WRL model submitted in 1:2.54 scale
  • 3D model alignment checked against KiCad footprint
  • WRL model uses correct material properties
  • Geometry check performed against mechanical models

@easyw
Copy link
Contributor

easyw commented Dec 27, 2019

Hi @andrewzuku,
you should lay your model pins on xy plane with z=0.
For mechanical needs, only external dimensions are relevant, so no extra details are required IMO.
Just please check the STEP model is unioned (fused) in a single object.
Thanks for your contribution.

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new package 3D to library Pending reviewer A pull request waiting for a reviewer labels Jan 2, 2020
All bodies have been updated so that the leads end up touching the XY plane at z=0. Also, multiple bodies have been fused together.
@andrewzuku
Copy link
Author

Hi @easyw,

I've committed the changes you requested to my branch.

Once I've been through this process successfully once, I've got a few more 3D models i'd like to contribute. Thanks for taking the time to review this stuff :)

~ Andrew

@easyw
Copy link
Contributor

easyw commented Jan 3, 2020

@andrewzuku
I checked one STEP file model and it seems to perfectly fit the manufacturer's parameters and the footprint.
Just I forgot to tell you that the Label of the STEP model should match the Name of the file (in your STEP file the label is instead 'fusion'):
SW_SPST_TL3305A-Label

@Franck78
Copy link

Franck78 commented Sep 8, 2020

Three heights of this SW in the zip.
Please don't ask 'fix this name' or minor detail. Do it if needed and merge !

SW_SPST_TL3305x.zip

@andrewzuku
Copy link
Author

Sorry for neglecting this. I'll get onto it by the end of the weekend.

@Franck78
Copy link

Franck78 commented Sep 9, 2020

if for some reasons the 3 sets I made are not acceptable, here is where to 'set the height' of the actuator.
Remember also .step and wrml are text file. So if they want something like a name change, no need to reddo all the stuff of exporting.

Screenshot_20200909_162742

@evanshultz
Copy link
Collaborator

@Franck78
While I appreciate that you've been finding issues and jumping in, please be careful with your tone and words. @easyw absolutely knows the correct methods and processes and they do need to be followed. I know @chschlue has also pointed out a lack of politeness and we expect you to contribute positively in all KiCad repos as everybody is volunteering their time to grow and improve the libraries for all KiCad users.

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@Franck78
Copy link

Let's see if those 3 images will make it into now v 5.18......

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new package 3D to library Pending reviewer A pull request waiting for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants