-
Notifications
You must be signed in to change notification settings - Fork 747
Conversation
Here are some things that could be fixed.
There was a recent discussion about having a separate power symbol for even single-gate logic. I still support this so I want to resolve that discussion. I believe @jkriege2 was with me on this point. Also, the check scripts seem not to work which makes me too nervous to merge since we could use this as an example to fix it and check that they work. Let me know if you don't care to fix these, or at least not now. Bob's script may address some of them. |
Scripts are running now and I have touched a couple of the smaller issues |
This lib really needs a lot of work to get it all cleaned up. Ready to merge now as-is? |
I fear we don't have time to get the libs perfect before the v5 release. I would suggest we transfer the libs with minimal changes but document the problems we find as issues. If we then have time before the v5 release we can fix the problems then. (We could even ask for help over at the forum if we have well documented things to do.) |
Weren't some of these redone by @bobc with the help of scripting? I think we should merge for now and rework the remainder with scripts based on bobc's ones later |
As long as there are no critical issues that will break compatibility (such as the slashes in the other lib) then let's merge, raise an issue, and fix it at a later date. The priority is to transfer all the libs :) |
I reworked 74xx.lib and cmos4000.lib, I didn't touch the others but noticed that they could do with rework too. I am not surprised URLs don't work, URLs are notorious for becoming stale as web sites are reworked, I would be surprised if any expects URLs to keep working :) In fact, why do we bother with the datasheet URL anyway? All I do is google the part number and put it into the component, which is exactly what the user could do, and they will get an up to date link. The datasheet URL is just a very poor web cache. |
@poeschlr ok to merge? We should create an issue that these libs need to be fixed :) |
See #27. |
Merge master into add-analog-devices-ad7616
Added Logic libraries