Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add 74LS07 #1665

Merged
merged 10 commits into from Mar 26, 2019
Merged

Add 74LS07 #1665

merged 10 commits into from Mar 26, 2019

Conversation

b1ackmai1er
Copy link
Contributor

@b1ackmai1er b1ackmai1er commented Mar 21, 2019

Replace this line with your commit message! Please provide a description of your pull request


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@myfreescalewebpage myfreescalewebpage added Pending reviewer A pull request waiting for a reviewer Addition Adds new symbols to library labels Mar 21, 2019
@myfreescalewebpage
Copy link
Collaborator

@b1ackmai1er thanks for this contribution. Several question and comments:

  • Why the git diff is showing a so large difference ? This is not normal. Maybe you have got some issues with lien ending.
  • I think the device can be an alias of 74LCX07, isn't it ?
  • Finally, we expect from you to complete your pull request message with several information such as datasheet link and screenshot of the symbol, please update your previous message, this clearly simply the review of contribution and it is very important for us.
    Thanks,
    Joel

@b1ackmai1er
Copy link
Contributor Author

Hi Joel,
Line endings fixed - I think I understand what is causing this now (my text editor).
I saw the 74LXC07 part but the symbol did not match the data sheet symbol (center symbol).
Would you prefer and alias or a the new symbol which matched the data sheet? I am not sure what the center symbol signifies.
image
Apologies for not completing information - I rushed this.

Regards Phillip

@evanshultz
Copy link
Collaborator

That symbol means the pin is open collector. It's in IEEE 91-1984.

I'm not aware of any rules/guidelines for this in the library now so perhaps it's time to decide. Librarians? My feeling is that this helps to catch mistakes with visual checking, but a more robust solution is to have automated checking (like for missing pullup resistors, in this case) and that's a better way to go. My experience is that these open collector symbols are wildly inconsistent in the industry so it's not obvious there is a "correct" solution and we can decide what goes into KLC on this point.

@b1ackmai1er
Copy link
Contributor Author

Oops forgot data sheet again: www.ti.com/lit/ds/symlink/sn74ls07.pdf

@myfreescalewebpage
Copy link
Collaborator

@b1ackmai1er I do not know about the symbol. @evanshultz probably this is something to think more generally. Anyway, the 74LCX07 has Open Collector output too, so your symbol can be an alias of this one:

Capture

Joel

@myfreescalewebpage myfreescalewebpage self-assigned this Mar 23, 2019
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Mar 23, 2019
@evanshultz
Copy link
Collaborator

Yes. I say move ahead here and pin symbols can be a separate discussion. We already require separate symbols if pin types are different, so this is only a visual thing and won't affect our library otherwise.

@b1ackmai1er
Copy link
Contributor Author

Hi gents, Changed to aliases as requested.

@myfreescalewebpage
Copy link
Collaborator

Thanks @b1ackmai1er for the modification.
However, the new footprint filter for DIP-14 should be DIP*W7.62mm*.
Joel

@b1ackmai1er
Copy link
Contributor Author

Hi I have update this and other DIP?14* entries to DIPW7.62mm
In the process I have actually rause a PUSH/Patch request by mistake. Any idea how to cancel that?
Travis reporting huge amount of errors which I do not understand.

@myfreescalewebpage
Copy link
Collaborator

The travis warnings and errors are due to the fix of the footprint filters, this is normal.
No more comment to do, I think we can merge.

@myfreescalewebpage myfreescalewebpage merged commit c9164d6 into KiCad:master Mar 26, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 6.0.0 milestone Mar 27, 2019
@antoniovazquezblanco antoniovazquezblanco modified the milestones: 6.0.0, 5.1.1 Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants