Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Relay and Relay_SolidState symbol cleanup #1984

Merged
merged 3 commits into from
Sep 22, 2019

Conversation

evanshultz
Copy link
Collaborator

Fixes #1956.

No pins changed position at all! Little to no changes to the actual symbols; this is about making things more elegant. However, there were some small changes to the solid state symbols so here are are a couple reference images:
image
image
image
image

Relay:
-Pin name offset to 20mil
-Use as few lines as possible
-Diodes are unfilled with a middle line
-Shrack relays to diagonal line coil style
-Convert polylines of characters to text
-Make text upright when viewed in libedit
-Move NC pins to symbol outline

Relay_SolidState:
-Use as few lines as possible
-Diodes are unfilled with a middle line
-Move NC pins to symbol outline
-Set TLP148G as ALIAS of TLP141G

To avoid maintenance issues and make this the standard symbols from which users can take if they contribute new symbols, I'd really like to see this merged quickly. Thanks!


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

-Use as few lines as possible
-Diodes are unfilled with a middle line
-Move NC pins to symbol outline
-Set TLP148G as ALIAS of TLP141G
-Pin name offset to 20mil
-Use as few lines as possible
-Diodes are unfilled with a middle line
-Shrack relays to diagonal line coil style
-Convert polylines of characters to text
-Make text upright when viewed in libedit
-Move NC pins to symbol outline
@antoniovazquezblanco antoniovazquezblanco added Enhancement Improves existing symbol in the library Pending reviewer A pull request waiting for a reviewer labels Jul 16, 2019
@evanshultz
Copy link
Collaborator Author

Ping! Any chance to get this merged before branch conflicts?

@diegoherranz diegoherranz self-assigned this Aug 10, 2019
@diegoherranz diegoherranz removed the Pending reviewer A pull request waiting for a reviewer label Aug 10, 2019
@evanshultz
Copy link
Collaborator Author

@diegoherranz
You assigned this PR to yourself. I fixed one branch conflict so it's able to merge now. Were there any changes you wanted or any other issues?

@diegoherranz
Copy link
Collaborator

diegoherranz commented Sep 20, 2019

I haven't reviewed it yet, but I had interest in seeing this one merged, that's why I took it.
I'll review this weekend.
Thanks!

@diegoherranz diegoherranz added the Bug Fix symbol existing in the library label Sep 22, 2019
@diegoherranz
Copy link
Collaborator

diegoherranz commented Sep 22, 2019

I've added the bug label too since it also fixes a few NC pins which were outside of the symbol outline. Namely: MOC3010M, MOC3031M and FOD420 (in Relay_SolidState).
I've checked them and they look OK now.

@diegoherranz
Copy link
Collaborator

Some checks done:

  • TLP148G made an ALIAS of TLP141G: checked datasheets and it's safe to do

  • Lib files in this PR compared to those in master using https://github.com/KiCad/kicad-library-utils/blob/master/schlib/comparelibs.py with the --design-breaking-changes option.
    No difference in pin naming or placement except for the NC pins mentioned above.

  • I've randomly checked a few symbols and the graphical cleanup done looked OK.

Given the --design-breaking-changes check done above is OK, which is the most important thing, I'm happy to merge this even if I haven't individually checked every symbol. It is low risk and we can benefit from unified, tidy symbols in master before getting new submissions in these libraries.

Thanks, @evanshultz

@diegoherranz diegoherranz merged commit 4a9c786 into KiCad:master Sep 22, 2019
@evanshultz evanshultz deleted the relay-cleanup branch September 23, 2019 15:22
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Sep 24, 2019
pull bot pushed a commit to maximeborges/kicad-symbols that referenced this pull request Oct 5, 2019
* Clean up Relay_SolidState

-Use as few lines as possible
-Diodes are unfilled with a middle line
-Move NC pins to symbol outline
-Set TLP148G as ALIAS of TLP141G

* Clean up Relay

-Pin name offset to 20mil
-Use as few lines as possible
-Diodes are unfilled with a middle line
-Shrack relays to diagonal line coil style
-Convert polylines of characters to text
-Make text upright when viewed in libedit
-Move NC pins to symbol outline

* Resolve branch conflict
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix symbol existing in the library Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verbose relay symbols
3 participants