-
Notifications
You must be signed in to change notification settings - Fork 747
Relay and Relay_SolidState symbol cleanup #1984
Conversation
-Use as few lines as possible -Diodes are unfilled with a middle line -Move NC pins to symbol outline -Set TLP148G as ALIAS of TLP141G
-Pin name offset to 20mil -Use as few lines as possible -Diodes are unfilled with a middle line -Shrack relays to diagonal line coil style -Convert polylines of characters to text -Make text upright when viewed in libedit -Move NC pins to symbol outline
Ping! Any chance to get this merged before branch conflicts? |
@diegoherranz |
I haven't reviewed it yet, but I had interest in seeing this one merged, that's why I took it. |
I've added the bug label too since it also fixes a few NC pins which were outside of the symbol outline. Namely: MOC3010M, MOC3031M and FOD420 (in Relay_SolidState). |
Some checks done:
Given the Thanks, @evanshultz |
* Clean up Relay_SolidState -Use as few lines as possible -Diodes are unfilled with a middle line -Move NC pins to symbol outline -Set TLP148G as ALIAS of TLP141G * Clean up Relay -Pin name offset to 20mil -Use as few lines as possible -Diodes are unfilled with a middle line -Shrack relays to diagonal line coil style -Convert polylines of characters to text -Make text upright when viewed in libedit -Move NC pins to symbol outline * Resolve branch conflict
Fixes #1956.
No pins changed position at all! Little to no changes to the actual symbols; this is about making things more elegant. However, there were some small changes to the solid state symbols so here are are a couple reference images:
![image](https://user-images.githubusercontent.com/1936989/61318621-539c0400-a7ba-11e9-9c02-b50af1ff7a13.png)
![image](https://user-images.githubusercontent.com/1936989/61318633-5bf43f00-a7ba-11e9-983e-09ecd1d6523f.png)
![image](https://user-images.githubusercontent.com/1936989/61318660-657da700-a7ba-11e9-89eb-a77d7731669f.png)
![image](https://user-images.githubusercontent.com/1936989/61318689-7c23fe00-a7ba-11e9-903b-e5aeb51d8ff5.png)
Relay:
-Pin name offset to 20mil
-Use as few lines as possible
-Diodes are unfilled with a middle line
-Shrack relays to diagonal line coil style
-Convert polylines of characters to text
-Make text upright when viewed in libedit
-Move NC pins to symbol outline
Relay_SolidState:
-Use as few lines as possible
-Diodes are unfilled with a middle line
-Move NC pins to symbol outline
-Set TLP148G as ALIAS of TLP141G
To avoid maintenance issues and make this the standard symbols from which users can take if they contribute new symbols, I'd really like to see this merged quickly. Thanks!
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: