This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Microchip #57
Merged
Microchip #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to decide how to categorize
|
Should the I/O expanders go int interface_i2c and interface_spi? (currently you have them in the legacy lib.) |
|
Interface_xxx libs are for parts that use an xxx interface to communicate with something off-board and xxx is their primary functionality. In this case the primary function is I/O expansion and not SPI or I2C. We just need to develop a good category.for these. |
|
Ok i misunderstood the note in the lib reorg discussion thread. In that case thanks |
4 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the existing
microchip.libacross.The easy to categorize symbols have been allocated.
The remaining ones are in
legacy/microchip.libMy strategy is to move the easy ones first which I can do very quickly. Then for the few remaining ones we will have to go through and decide on categorization.