Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add symbol for SIM800C #634

Merged
merged 4 commits into from
Jun 28, 2018
Merged

Add symbol for SIM800C #634

merged 4 commits into from
Jun 28, 2018

Conversation

jneiva08
Copy link
Contributor

@jneiva08 jneiva08 commented May 29, 2018

Added symbol for SIMCOM SIM800C.

The datasheet is: http://simcom.ee/documents/SIM800C/SIM800C_Hardware_Design_V1.05.pdf

The symbol is the following:

sim800c_symbol

This PR for SIM800C footprint #615


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@Misca1234
Copy link
Collaborator

Misca1234 commented Jun 10, 2018

Hi

Why have you renamed pin 9 and 10 to MIC_P and MIC_N when the data sheet ways MICP and MICN (same goes for pin 11 and 12)?

Pin 39, PWRKEY is active low, add a '~' before the P in PPWRKEY to get the line above the text.

Pin 18, SIM_VDD, is a power output for the SIM card, normally this one should be on the top of the symbol, but it kinda belong to the SIM card stuff, but that rises the question about pin 40, VDD_EXT, perhaps it should be at the top right corner so the symbol is consequent, I am not sure about this?

Pin 17, SIM_RST, I am not familiar with sim card but if the reset signal is active low it should have a '~' before the S in SIM_RST

@Misca1234
Copy link
Collaborator

Misca1234 commented Jun 10, 2018

Another thing (which made me change the last comment)
On page 13, pin 26 is named USB_DN but on page 14 the same pin is named USB_DM?
This must be a manufacture typo, I guess they represent the negative and positive lines,
which then must mean USB_DP is positive and and therefore pin 26 should be negative and the name USB_DN makes more sense.

What are your thoughts ?

@Misca1234
Copy link
Collaborator

You should align the bottom line of the symbol to the GND pins as well, now the GND pins "hangs in the air"

@jneiva08
Copy link
Contributor Author

I added "_N" to MIC and SPK to be identical to SIM900. Already fix it.
The USB DP/DN pins should be a typo, I followed pin description table pag.14 (the Microchip usb hub uses DP/DM).
The SIM pins should be all grouped, the sim_rst don't need '~'. (Can seen SIM900 and UL865 on library)

@evanshultz
Copy link
Collaborator

@jneiva08

  • Can ADC be on the left side since it's an input?
  • And maybe pins 41/42 on the right side?
  • We have used Passive type for antenna pins in the past because they only go to passive parts or traces.
  • I also think the symbol could be shrunk a bit.
  • Flip the symbol ref des and name so ref des is on top.

Just a question for my own information since Google shows loads of DP/DM and DP/DN. P and N are obvious as Positive and Negative; why use M? Do you know? I don't see an explanation of why after a quick online search, even though it is a common nomenclature.

Can you post a new screenshot after all of the changes requested above?

@Shackmeister
Copy link
Collaborator

DP is Data Plus or D+
DM is Data Minus or D-

* VBUS now is on top,
* Shrunk a lot vertically,
* Moved around some pins,
* Antenna pins is now passive.
@jneiva08
Copy link
Contributor Author

have already made the alterations requested.

Now looks like this:
sim800c

@Misca1234
Copy link
Collaborator

@Shackmeister
Yes, if you look in the data sheet the manufacture is naming pin 14 (supposedly minus) in two different ways, on page 13, pin 26 is named USB_DN but on page 14 the same pin is named USB_DM?

So they use "minus" and "negative" for the minus pin so the question was name should be used for pin 14, USB_DN or USB_DM (the "plus" pin have the "same" problem)

@evanshultz
Copy link
Collaborator

I only have one more comment: I'd like to see the MIC* and SPK* pins separated from other pins since their functions are discrete. It looks like it may require the symbol to grow?

@jneiva08
Copy link
Contributor Author

I could make a trade, put back the USB VBUS and grow a little vertically and decrease horizontally?

@evanshultz
Copy link
Collaborator

Sure. If it looks nice to you then make a commit and screenshot to everyone can quickly see it too. Thanks!

@jneiva08
Copy link
Contributor Author

done, now looks:

sim800c

@evanshultz
Copy link
Collaborator

Looks good to me! Thanks for all your work on this symbol!

@evanshultz evanshultz merged commit 8501bba into KiCad:master Jun 28, 2018
@jneiva08 jneiva08 deleted the sim800c branch June 28, 2018 20:05
@jneiva08 jneiva08 mentioned this pull request Dec 12, 2018
5 tasks
@myfreescalewebpage myfreescalewebpage added the Addition Adds new symbols to library label May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants