-
Notifications
You must be signed in to change notification settings - Fork 746
Conversation
Hi Why have you renamed pin 9 and 10 to MIC_P and MIC_N when the data sheet ways MICP and MICN (same goes for pin 11 and 12)? Pin 39, PWRKEY is active low, add a '~' before the P in PPWRKEY to get the line above the text. Pin 18, SIM_VDD, is a power output for the SIM card, normally this one should be on the top of the symbol, but it kinda belong to the SIM card stuff, but that rises the question about pin 40, VDD_EXT, perhaps it should be at the top right corner so the symbol is consequent, I am not sure about this? Pin 17, SIM_RST, I am not familiar with sim card but if the reset signal is active low it should have a '~' before the S in SIM_RST |
Another thing (which made me change the last comment) What are your thoughts ? |
You should align the bottom line of the symbol to the GND pins as well, now the GND pins "hangs in the air" |
I added "_N" to MIC and SPK to be identical to SIM900. Already fix it. |
Just a question for my own information since Google shows loads of DP/DM and DP/DN. P and N are obvious as Positive and Negative; why use M? Do you know? I don't see an explanation of why after a quick online search, even though it is a common nomenclature. Can you post a new screenshot after all of the changes requested above? |
DP is Data Plus or D+ |
* VBUS now is on top, * Shrunk a lot vertically, * Moved around some pins, * Antenna pins is now passive.
@Shackmeister So they use "minus" and "negative" for the minus pin so the question was name should be used for pin 14, USB_DN or USB_DM (the "plus" pin have the "same" problem) |
I only have one more comment: I'd like to see the MIC* and SPK* pins separated from other pins since their functions are discrete. It looks like it may require the symbol to grow? |
I could make a trade, put back the USB VBUS and grow a little vertically and decrease horizontally? |
Sure. If it looks nice to you then make a commit and screenshot to everyone can quickly see it too. Thanks! |
Put USB VBUS and near USB Data pins
Looks good to me! Thanks for all your work on this symbol! |
Added symbol for SIMCOM SIM800C.
The datasheet is: http://simcom.ee/documents/SIM800C/SIM800C_Hardware_Design_V1.05.pdf
The symbol is the following:
This PR for SIM800C footprint #615
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: