-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests-from-pull-requests): should return array of test names #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.eslintrc:
.eslintrc: Configuration for rule "linebreak-style" is invalid: Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed 'undefined').Error: .eslintrc:
at validateRuleOptions (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:119:19)
at Object.keys.forEach.id (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:162:9)
at Array.forEach ()
at validateRules (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:161:30)
at Object.validate (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:239:5)
at loadFromDisk (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:516:19)
at Object.load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:179:43)
at Config.getConfigVector (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:286:21)
b1f8c32
to
80c63a9
Compare
754b096
to
919af01
Compare
919af01
to
0d06915
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Most of the changes a cosmetic.
When you want to submit changes here, stage your changes and instead of running npm run commit
to create a new commit, run git commit --amend
, which will add your staged files into the last commit (this one). when the editor opens, just type on you keyboard :wq
to write
and quit
the editor
0d06915
to
c9cc6ce
Compare
c9cc6ce
to
223c2a1
Compare
223c2a1
to
de78b6e
Compare
de78b6e
to
d8c4b72
Compare
d8c4b72
to
98005b1
Compare
98005b1
to
afa8391
Compare
returns an array of parsed strings that declare the tests written in specs
afa8391
to
7488472
Compare
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
returns array of parsed strings that declare the tests written in specs