Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests-from-pull-requests): should return array of test names #24

Merged
merged 1 commit into from
Jan 12, 2019

Conversation

dunaevsky
Copy link
Member

returns array of parsed strings that declare the tests written in specs

@dunaevsky dunaevsky requested review from thatkookooguy and a team December 12, 2018 11:12
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.eslintrc:
.eslintrc:
	Configuration for rule "linebreak-style" is invalid:
	Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed 'undefined').

Error: .eslintrc:
at validateRuleOptions (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:119:19)
at Object.keys.forEach.id (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:162:9)
at Array.forEach ()
at validateRules (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:161:30)
at Object.validate (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:239:5)
at loadFromDisk (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:516:19)
at Object.load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:179:43)
at Config.getConfigVector (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:286:21)

@coveralls
Copy link

coveralls commented Dec 12, 2018

Coverage Status

Coverage remained the same at 12.162% when pulling 7488472 on get-test-from-pr-real into b806fb1 on master.

@thatkookooguy thatkookooguy removed the request for review from a team December 12, 2018 11:34
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/lint-pull-request.js Outdated Show resolved Hide resolved
lib/check-pr-tdd.js Outdated Show resolved Hide resolved
lib/check-pr-tdd.js Outdated Show resolved Hide resolved
Copy link
Member

@thatkookooguy thatkookooguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Most of the changes a cosmetic.

When you want to submit changes here, stage your changes and instead of running npm run commit to create a new commit, run git commit --amend, which will add your staged files into the last commit (this one). when the editor opens, just type on you keyboard :wq to write and quit the editor

lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Show resolved Hide resolved
lib/tests-from-pull-request.js Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
lib/tests-from-pull-request.js Show resolved Hide resolved
lib/tests-from-pull-request.js Outdated Show resolved Hide resolved
returns an array of parsed strings that declare the tests written in specs
@dunaevsky dunaevsky merged commit cd53d1b into master Jan 12, 2019
@dunaevsky dunaevsky deleted the get-test-from-pr-real branch January 12, 2019 11:43
@thatkookooguy
Copy link
Member

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants