Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for more locations of System.map #41

Merged
merged 1 commit into from Dec 8, 2019
Merged

Check for more locations of System.map #41

merged 1 commit into from Dec 8, 2019

Conversation

madaidan
Copy link
Contributor

@madaidan madaidan commented Dec 7, 2019

@@ -5,8 +5,10 @@

shopt -s nullglob

system_map_location="/boot/System.map* /usr/src/*/System.map* /lib/modules/*/*/System.map* /System.map*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this? I guess this possibly won't work. The * inside quotes " is just a character. Does not expand.

Or does it expand later in ${system_map_location} since that does not use quotes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does it expand later in ${system_map_location} since that does not use quotes?

Yes it does.

Running:

for i in ${system_map_location}; do   echo $i; done

on my host outputs:

/boot/System.map*
/usr/src/linux-hardened/System.map
/usr/src/linux/System.map
/lib/modules/5.3.13.a-1-hardened/build/System.map
/lib/modules/5.3.13-arch1-1/build/System.map
/System.map*

so it does expand.

The * only becomes a character when the files don't exist which isn't a problem as we check if the files do exist further down.

@adrelanos adrelanos merged commit a78a7e5 into Kicksecure:master Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants