You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When making use of the --branch parameter to push changes to a gh-pages branch, instead of adding docs in with the master branch, it attempts to make a directory at /docs (root of the file system) without also specifying an --outputDirectory parameter.
I'd be willing to help with any changes here, keen to hear your thoughts. Might just be a case of being a bit more explicit in the readme?
The text was updated successfully, but these errors were encountered:
dayvidwhy
changed the title
Setting 'branch' parameter needs 'outputDirectory' as well.
Setting 'branch' parameter to something other than 'master' needs 'outputDirectory' as well.
Jun 9, 2018
This should be a pretty simple fix, but it is definitely a bug and not expected behavior, so it should be fixed.
Should be easy enough, I'll go ahead and reproduce it and look more into it tonight.
Okay, I changed the logic for the output directory to check if it was different than the default, rather than based off the branch.
I chose to do it this way because basing the output path off the branch, rather than the output path itself was never great.
If I've missed anything or it still doesn't work let me know, it's always a possibility.
Thanks for reporting this and the detailed info, I was able to see the problem immediately
When making use of the
--branch
parameter to push changes to agh-pages
branch, instead of adding docs in with the master branch, it attempts to make a directory at/docs
(root of the file system) without also specifying an--outputDirectory
parameter.This behaviour can be seen because of;
https://github.com/KieferSivitz/vue-gh-pages/blob/master/index.js#L120
I'd be willing to help with any changes here, keen to hear your thoughts. Might just be a case of being a bit more explicit in the readme?
The text was updated successfully, but these errors were encountered: