Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting 'branch' parameter to something other than 'master' needs 'outputDirectory' as well. #26

Closed
dayvidwhy opened this issue Jun 9, 2018 · 3 comments
Assignees
Labels

Comments

@dayvidwhy
Copy link

dayvidwhy commented Jun 9, 2018

When making use of the --branch parameter to push changes to a gh-pages branch, instead of adding docs in with the master branch, it attempts to make a directory at /docs (root of the file system) without also specifying an --outputDirectory parameter.

This behaviour can be seen because of;
https://github.com/KieferSivitz/vue-gh-pages/blob/master/index.js#L120

I'd be willing to help with any changes here, keen to hear your thoughts. Might just be a case of being a bit more explicit in the readme?

@dayvidwhy dayvidwhy changed the title Setting 'branch' parameter needs 'outputDirectory' as well. Setting 'branch' parameter to something other than 'master' needs 'outputDirectory' as well. Jun 9, 2018
@KieferSivitz KieferSivitz self-assigned this Jun 11, 2018
@KieferSivitz
Copy link
Owner

KieferSivitz commented Jun 11, 2018

EDIT: unnecessary info removed.

This should be a pretty simple fix, but it is definitely a bug and not expected behavior, so it should be fixed.
Should be easy enough, I'll go ahead and reproduce it and look more into it tonight.

@KieferSivitz
Copy link
Owner

KieferSivitz commented Jun 11, 2018

Okay, I changed the logic for the output directory to check if it was different than the default, rather than based off the branch.

I chose to do it this way because basing the output path off the branch, rather than the output path itself was never great.

If I've missed anything or it still doesn't work let me know, it's always a possibility.
Thanks for reporting this and the detailed info, I was able to see the problem immediately

EDIT: Version 1.16.3

@dayvidwhy
Copy link
Author

This looks good to me, thanks for your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants