fix: teardown happening during initial setup #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caffeinated-pixels
requested review from
masonbraun,
thedaviddias and
jmanrumartinez
thedaviddias
approved these changes
Feb 6, 2024
thedaviddias
pushed a commit
that referenced
this pull request
Feb 6, 2024
## Description This fixes an issue that can occur if the AdvertisingProvider unmounts during the initial GPT setup. I've added a new state value (isInitialSetupComplete), which gets set when the setup completes and prevents `omponentWillUnmount` from calling the teardown function. This ensures we don't create a race condition between the setup and teardown, which can break the display ads. Co-authored-by: Stephen Gill <stephen.gill@adevinta.com>
thedaviddias
pushed a commit
that referenced
this pull request
Feb 7, 2024
thedaviddias
pushed a commit
that referenced
this pull request
Feb 7, 2024
caffeinated-pixels
added a commit
that referenced
this pull request
Feb 8, 2024
## Description - Follow-up from PR #134 - Adds in the missing setState for updating isInitialSetupComplete. I must of deleted it by accident when I was removing all my console logs 😞 Co-authored-by: Stephen Gill <stephen.gill@adevinta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue that can occur if the AdvertisingProvider unmounts during the initial GPT setup.
I've added a new state value (isInitialSetupComplete), which gets set when the setup completes and prevents
omponentWillUnmountfrom calling the teardown function. This ensures we don't create a race condition between the setup and teardown, which can break the display ads.