Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to click cursor to the start of any line of text (1.4.1) #71

Closed
Jamezhall opened this issue Jul 31, 2018 · 11 comments
Closed

Unable to click cursor to the start of any line of text (1.4.1) #71

Jamezhall opened this issue Jul 31, 2018 · 11 comments

Comments

@Jamezhall
Copy link

Issue: Cannot click the beginning of a line of text or place cursor there with left mouse click. See below.
Version: 1.4.1
OS: Windows 10

fs1 4 1-margin-issue

Loving all the new updates - looks like 1.4.1 broke something though. Hope this can help!

@Jamezhall Jamezhall changed the title Unable to click / move cursor to start of any line of text (1.4.1) Unable to click cursor to the start of any line of text (1.4.1) Jul 31, 2018
@AndrewWhiteat70ms
Copy link

I'm having the same problem, except that when I click that region, I can collapse the text. I think the gutter is too wide, and is overlapping the text.

@Kilian
Copy link
Owner

Kilian commented Aug 8, 2018

I think #71 and #70 are caused by the same issue, and that is that the gutters (blank area next to the text) are no longer sized correctly. I'll investigate! I think my changes for #44 might've changed this.

@Jamezhall
Copy link
Author

@Kilian Out of interest is there any eta on a fix? Not being able to select the beginning of the line is kind of a bummer 😊
I'm not sure how it works but would a small fixed gutter make sense, similar to most IDEs? (as opposed to it scaling?)

@Juje
Copy link

Juje commented Aug 28, 2018

@Kilian For some reason the fold/unfold buttons get clicked if you click in the non click zone.
This can be tested with something like:

- Foo
	- Bar
- Foos
- Bas

It folds even if you click on Bas or Foos.
So it looks like the clicking area for the fold/unfold buttons seems to big.

@Kilian
Copy link
Owner

Kilian commented Sep 1, 2018

I think this is fixed by this version, mac only for now (at least it is for me): https://github.com/Kilian/fromscratch/releases/download/v1.4.2-beta/FromScratch-1.4.2.dmg

@AndrewWhiteat70ms
Copy link

Works for me! Thanks, Killian!

@Juje
Copy link

Juje commented Sep 6, 2018

The issue is indeed fixed 😄 (using the latest version from master (6861e8c)).

But the clicking area is still too big in my honest opinion.

For the below text when you click next to the word test it closes the whole paragraph above it which is weird to be honest.

You can type neat arrows like these: ->, -->, ->> and =>, courtesy of the font "Fira Code".

	FromScratch also does automatic indenting
	and more. So delete this text & let's go!+
	
test

But you can again click on words at the beginning of the line which is really good 😄

@Kilian
Copy link
Owner

Kilian commented Sep 6, 2018

You're right, but that's less easy to change, since it's internal listeners that are being set by codemirror (the text editor powering from scratch) that I don't have direct access to. I'll see if there are ways to improve that!

@Juje
Copy link

Juje commented Sep 6, 2018

@Kilian Ok awesome to hear 😄
And thank you for maintaining FromScratch and keeping the bugs out.

@Jamezhall
Copy link
Author

Looking forward to the M$ Windows version! (sorry, i'm a windows pleb - not by choice - its what i'm using at work) :(

@Kilian
Copy link
Owner

Kilian commented Sep 22, 2018

released: https://github.com/Kilian/fromscratch/releases/tag/v1.4.2

@Kilian Kilian closed this as completed Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants