-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live preview #234
Closed
Closed
Live preview #234
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
17c474c
Live preview
sebaxakerhtc e938c47
Live preview
sebaxakerhtc 1e22e87
Live preview
sebaxakerhtc da4fc4f
Translated from Russian to English
sebaxakerhtc a434f2d
Increase pause
sebaxakerhtc d7ca476
Edited by recommendation of @FoxxMD
sebaxakerhtc 265709d
Merge branch 'Kilvoctu:main' into Live-preview
sebaxakerhtc cfae091
Spoiler support for Live preview
sebaxakerhtc 12a07ef
Looks like better solution for me
sebaxakerhtc e70bf01
Revert "Looks like better solution for me"
sebaxakerhtc 818d829
Use job presence to detect end of generation
FoxxMD a7f46ab
Make progress interval check configurable
FoxxMD 9548e40
Merge pull request #11 from FoxxMD/Live-preview-foxx
sebaxakerhtc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may also be an issue. What I'm experiencing:
/draw
dream
)I believe I am seeing this because my generation times are under ~8 seconds (using 3070 and SDXL Lightning) but the
update_progress
task waits at least 10 tries before finishing, regardless of whether the generation is done yet or not.Based on my breakpoints what I see happening:
/draw
event_loop
post_dream
because queue is still full ofupdate_progress
tasks that keep being createdupdate_progress
hits 10 tries and exits, queue is cleared, and eventually gets topost_dream
where it queues up finished image messageI see that the progress view is also deleted once
post_dream
starts so that seems like a good order to do things in but waiting forupdate_progress
to finish takes too long.This isn't perfect but its doing better:
The main difference is that it returns from update_progress if the previous task got an image and the current task did not.
EDIT: I think it may be better to do the "has" check but check for empty string in
progress_data["state"]["job"]
instead. With a small 1-2 try buffer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version using jobs...this seems to work better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there was a
time.sleep(1)
no errors but messages404
That's why here I replaced 1 with 3
Bad choice.