-r doesn't work, reverting to -i #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on ubuntu 20.04, anaconda python 3.7.1, TShark (Wireshark) 3.2.3 (Git v3.2.3 packaged as 3.2.3-1). KimiNewt#477 KimiNewt#299 with LiveRingCapture and -r it just crashed, as in these issues. With LiveCapture it would drop packets. With LiveRingCapture and -i it works without dropping packets. I did not run for a long period of time yet to see how long it runs without drops. My packet rate is relatively low.
|
Thanks @squigdawg for finding my misdirected pull request. I'm new to this PR thing. |
|
I wonder if this is still necessary for LiveCapture? Using LiveRingCapture would still need to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on ubuntu 20.04, anaconda python 3.7.1, TShark (Wireshark) 3.2.3 (Git v3.2.3 packaged as 3.2.3-1).
#477
#299
with LiveRingCapture and -r it just crashed, as in these issues. With LiveCapture it would drop packets. With LiveRingCapture and -i it works without dropping packets. I did not run for a long period of time yet to see how long it runs without drops. My packet rate is relatively low.
UPDATE from SquigDawg 2/28/2022: Found this in poleguy's fork and it fixed the issue I was having. But his pull request wasn't up to the KimiNewt/pyshark parent repo.