Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some params for LiveRingCapture. #563

Merged
merged 1 commit into from Jul 9, 2022

Conversation

miaotony
Copy link
Contributor

@miaotony miaotony commented Jul 4, 2022

When a user use LiveRingCapture with include_raw=True, it will return use_json must be True if include_raw. However, LiveRingCapture doesn't have use_json parameter.

In the source code, I find that LiveRingCapture derives from LiveCapture but it doesn't provide the proper parameters to be passed to its parent class.

So I add some parameters for LiveRingCapture to solve this problem.

@miaotony
Copy link
Contributor Author

miaotony commented Jul 8, 2022

cc @KimiNewt

@KimiNewt KimiNewt merged commit 7025d97 into KimiNewt:master Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants