-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CaptureContext class to simplify code in hooks #13
Conversation
😢 https://ci.appveyor.com/project/KindDragon/vld/build/140/job/4m8viq3lfecrlcpf/tests |
https://ci.appveyor.com/project/KindDragon/vld/build/146/job/vc1g5ofkc7ee05ut a lot of messages "VLD: New allocation at already allocated address: 0x00E09700 with size: 164 and new size: 164" |
I think the root of the failure with the following builds is that the debug symbols for If you take a look at the following call stack, taken from the above builds, before the call to Never the less skipping startup CRT allocations depends on all the debug symbols being loaded, so we should investigate why these symbols were not loaded in the first place.
|
Hmm, appveyor always reproduce this bug with VldStackWalkMethod=fast, Toolset=v120_xp |
Maybe instead of file paths we should test for function names that are called within startup crt and make allocations ? Did you manage to understand why these messages arise? |
I will try reproduce it locally |
|
I think it's bug in v120 CRT |
One of two 😄 |
👍 |
Use CaptureContext class to simplify code in hooks
Will you release the RC now, or are there any more pending matters ? |
We have new false positive leaks in VS2015 😢 https://gist.github.com/akaStiX/fde381ec7e29a7264b9b |
Can you include a test case for https://gist.github.com/akaStiX/fde381ec7e29a7264b9b maybe in I think adding |
I can't reproduce it ATM in vld tests 😢 |
Try in vld_main the following code
|
Does VS2015
We could simply use the following to exclude all |
Tested the above and it seems to work perfectly :) |
I'll do later |
Maybe I'm doing something wrong, but I can't reproduce it. |
VS2015, v140, Release_StaticCrt |
This commit 1ad587e should fix issue |
I was working on cleaning up 3 commits |
Changes from 120d622 no longer needed |
I'd suggest changes in |
Does 120d622 resolve this ? Note that this is with VS2013 with the code posted above.
|
I'll try your code again |
no need to include both |
It's only in Release with StaticCrt https://ci.appveyor.com/project/KindDragon/vld/build/161 |
Yes the fix with ucrt is only for debug mode! As i thought appveyor reports cerr to its console in red
|
@ioannis-e gitter chat to simplify discussion on issues https://gitter.im/KindDragon/vld |
Document special case in vld_unload test
Enable capturing vector_new... in msvcrtPatch
Skip stack trace for frames internal to vld
Use CaptureContext class to simplify code in hooks