modify code in showWithCallback(boolean successVisible)

KingJA · Mar 20, 2018 · a4ce9bb · a4ce9bb
1 parent 25eb053
commit a4ce9bb
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 7 deletions.
diff --git a/README-cn.md b/README-cn.md
@@ -60,7 +60,7 @@ LoadSir的使用，只需要简单的三步
 ### 添加依赖
 
 ```groovy
-compile 'com.kingja.loadsir:loadsir:1.3.5'
+compile 'com.kingja.loadsir:loadsir:1.3.6'
 ```
 
 ### 第一步：配置

diff --git a/README.md b/README.md
@@ -57,7 +57,7 @@ LoadSir only needs 3 steps: **1. Config** -> **2. Register** -> **3. Display**
 ### Download
 
 ```groovy
-compile 'com.kingja.loadsir:loadsir:1.3.5'
+compile 'com.kingja.loadsir:loadsir:1.3.6'
 ```
 
 ### Step 1: Config

diff --git a/app/src/main/java/sample/kingja/loadsir/target/AnimateActivity.java b/app/src/main/java/sample/kingja/loadsir/target/AnimateActivity.java
@@ -37,7 +37,7 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
         LoadSir loadSir = new LoadSir.Builder()
                 .addCallback(new EmptyCallback())
                 .addCallback(new AnimateCallback())
-                .setDefaultCallback(EmptyCallback.class)
+                .setDefaultCallback(AnimateCallback.class)
                 .build();
         loadService = loadSir.register(this, new Callback.OnReloadListener() {
             @Override
@@ -55,5 +55,6 @@ public void run() {
                 }).start();
             }
         });
+        PostUtil.postCallbackDelayed(loadService, EmptyCallback.class, 1000);
     }
 }
diff --git a/config.gradle b/config.gradle
@@ -4,7 +4,7 @@ ext {
     minSdkVersion = 14
     targetSdkVersion = 26
 
-    versionCode = 20171231
-    versionName = "1.3.5"
+    versionCode = 20180320
+    versionName = "1.3.6"
     supportVersion = '26.0.0-alpha1'
 }
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -1,5 +1,9 @@
 Changelog
 ---
+
+**1.3.6**
+- [x] modify code in`showWithCallback(boolean successVisible)`, use INVISIBLE instead of GONE thanks @X
+
 **1.3.5**
 - [x] add API `public Class<? extends Callback> getCurrentCallback()`
 - [x] deprecated API `public LinearLayout getTitleLoadLayout(Context context, ViewGroup rootView, View titleView)`

diff --git a/loadsir/src/main/java/com/kingja/loadsir/callback/SuccessCallback.java b/loadsir/src/main/java/com/kingja/loadsir/callback/SuccessCallback.java
@@ -24,15 +24,15 @@ protected int onCreateView() {
      * @deprecated Use {@link #showWithCallback(boolean successVisible)} instead.
      */
     public void hide() {
-        obtainRootView().setVisibility(View.GONE);
+        obtainRootView().setVisibility(View.INVISIBLE);
     }
 
     public void show() {
         obtainRootView().setVisibility(View.VISIBLE);
     }
 
     public void showWithCallback(boolean successVisible) {
-        obtainRootView().setVisibility(successVisible ? View.VISIBLE : View.GONE);
+        obtainRootView().setVisibility(successVisible ? View.VISIBLE : View.INVISIBLE);
     }
 
 }