Use filesystem library #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kingcom
force-pushed
the
filesystem
branch
2 times, most recently
from
6e5e282
to
f0bc166
Compare
sp1187
approved these changes
Jul 18, 2020
Kingcom
force-pushed
the
filesystem
branch
13 times, most recently
from
8e231a3
to
1ead611
Compare
Kingcom
force-pushed
the
filesystem
branch
5 times, most recently
from
19f9399
to
ea96057
Compare
std::filesystem platform support is unfortunatetly not yet where it needs to be. Also adds an option to force usage of std::filesystem
They come with the extra benefit of also supporting filesystem paths
Both std::filesystem and ghc::filesystem are pretty heavy headers, this increases the throughput by 200% on my machine
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses an implementation of the std::filesystem interface instead of the handwritten functions in various places. I've also added a test to verify the behavior of includes.
std::filesystem is not widely supported on all platforms yet, hence the third party library. However, there's a CMake option to switch to an official std::filesystem implementation. Either implementation is pretty rough on compile times, so an option for precompiled headers is also added.