-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WinUI like Resource Management and Localization #225
Conversation
I won't recommend merging this PR without a discussion and proper planning. Even though this PR would benefit porting of new controls, this may break this library. Think and decide. I'll wait. And oh my! The changes are quite large 😅 (~50k lines?). Please look carefully at just the code changes and not the |
Please take a look at this carefully #202 (comment) |
398aa13
to
5e5eb5b
Compare
The PR is ready to be merged. Well looks like the CI failed while installing deps. The build process didn't even start. So, I guess it not a problem. |
- Resolved suggestions - Included support for every control possible - Updated Strings.*.resx files
81109fc
to
bc762c3
Compare
Great work. I noticed the |
Looks great! You simplified it really well! |
Glad to hear! Would you like to update the PR to incorporate those changes before merging? Or I can do it after merging. |
I stopped programming. So, you have to do the changes yourself after merging this PR. |
I see. Thank you very much for your contributions and help! |
Fixes #202.