Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毀Update OpenAL #102

Open
9 of 12 tasks
CalvinWilkinson opened this issue Aug 31, 2022 · 2 comments
Open
9 of 12 tasks

馃毀Update OpenAL #102

CalvinWilkinson opened this issue Aug 31, 2022 · 2 comments
Assignees
Labels
馃摝dependency update Dependency update with required code changes medium priority Medium Priority preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Aug 31, 2022

Complete The Item Below

  • I have updated the title without removing the 馃毀 emoji.

Description

Update the OpenAL libraries.

The current version being used is v1.21.1. The version to update should be v1.23.0.
For the windows binaries, make sure to right click each file and confirm the versions.

In the project, there is a directory where you need to put the libraries for each platform. The 3 platforms are linux-64, win-x64, and win-x86.

We are not supporting win-x86 anymore. This directory can be deleted.
There is also some setup in the csproj file to pack the win-x86 version of the file into the NuGet package. This can be removed. Refer to diff below.

<Target Name="AddNativeWindowLibsToNugetPackage" AfterTargets="Build" Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU' Or '$(Configuration)|$(Platform)'=='Release|AnyCPU'">
    <ItemGroup>
      <!--WINDOWS-->
-      <Content Include="$(ProjectDir)OpenAL\libs\win-x86\*.dll" Pack="true" PackagePath="\runtimes\win-x86\native" />
      <Content Include="$(ProjectDir)OpenAL\libs\win-x64\*.dll" Pack="true" PackagePath="\runtimes\win-x64\native" />
      
      <!--LINUX-->
      <Content Include="$(ProjectDir)OpenAL\libs\linux-x64\*.so*" Pack="true" PackagePath="\runtimes\linux-x64\native" />
    </ItemGroup>
  </Target>

Other Info:

Windows
Get the Windows binaries here

Linux:
Linux binaries are not available and must be built.

  • OpenAL Soft
  • vcpkg

    Note This is a cross-plat C++ library manager and is used to help build windows & Linux binaries

Acceptance Criteria

  • OpenAL lib for win-x86 deleted
  • csproj updated to stop packing the win-x86 version of OpenAL into the NuGet package
  • win-x64 version of library updated
  • linux-64 version of library updated
  • NuGet package manually created and OpenAL files verified with correct version to verify that it is being packed

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct project (if applicable).
  • Issue linked to the correct milestone (if applicable).
  • Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 馃悰bug
Breaking Changes 馃Жbreaking changes
New Feature 鉁╪ew feature
Workflow Changes workflow
Code Doc Changes 馃棐锔廳ocumentation/code
Product Doc Changes 馃摑documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added 馃摝dependency update Dependency update with required code changes high priority High Priority labels Aug 31, 2022
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.11 milestone Aug 31, 2022
@CalvinWilkinson CalvinWilkinson self-assigned this Aug 31, 2022
CalvinWilkinson added a commit that referenced this issue Feb 11, 2023
@CalvinWilkinson CalvinWilkinson added the preview Done while in preview label Feb 11, 2023
@CalvinWilkinson CalvinWilkinson linked a pull request Feb 11, 2023 that will close this issue
12 tasks
@CalvinWilkinson CalvinWilkinson modified the milestones: v1.0.0-preview.12, v1.0.0-preview.13 May 30, 2023
@CalvinWilkinson CalvinWilkinson modified the milestones: v1.0.0-preview.13, TEMP FROM PREVIE.13, v1.0.0-preview.13ZZ, v1.0.0-preview.14 Jun 16, 2023
@CalvinWilkinson CalvinWilkinson added medium priority Medium Priority and removed high priority High Priority labels Aug 18, 2023
@CalvinWilkinson CalvinWilkinson added the on hold On Hold (Cannot Move Foward) label Nov 8, 2023
@CalvinWilkinson
Copy link
Member Author

Issue put on hold until the research results have been completed with the issue below:

The reason is because if OpenAL is replaced by RayLib, then there is no point in trying to update to the latest library

@CalvinWilkinson CalvinWilkinson removed this from the v1.0.0-preview.17 milestone Dec 5, 2023
@CalvinWilkinson CalvinWilkinson removed the on hold On Hold (Cannot Move Foward) label Mar 1, 2024
@CalvinWilkinson
Copy link
Member Author

Issue put on hold until the research results have been completed with the issue below:

The reason is because if OpenAL is replaced by RayLib, then there is no point in trying to update to the latest library

Issue taken off of hold status.

Reason:
The reason is that the research into the raylib replacement ended in a decision to keep using OpenAL to not lose maximum control over audio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃摝dependency update Dependency update with required code changes medium priority Medium Priority preview Done while in preview
Projects
Status: 馃彈锔廔n Development
Development

Successfully merging a pull request may close this issue.

1 participant