Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Search and replace all equality checks with pattern matching #780

Conversation

ljdarj
Copy link
Contributor

@ljdarj ljdarj commented Oct 28, 2023

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #101

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

    Note You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.30 milestone Oct 28, 2023
@CalvinWilkinson CalvinWilkinson changed the title Removing the last remaining !=/== null tests 🚧 Search and replace all equality checks with pattern matching Oct 28, 2023
@CalvinWilkinson CalvinWilkinson added tech-debt Code refactoring or cleanup / tech debt reduction low-priority Low Priority preview Done while in preview labels Oct 28, 2023
@CalvinWilkinson
Copy link
Member

@ljdarj Quick heads up. The name of your branch is incorrect. The branch is using underscores and they should by hyphens.

The branch should be named this:

- ljdarj:feature/101-equality_checks_to_pattern_matches
+ ljdarj:feature/101-equality-checks-to-pattern-matches

It is OK this time. It did not fail the status checks. Since the work has pretty much been finished, it would be too much work to have you rename/redo the branch. 😀

Just from now on, please make sure that the name of the branch is correct. Some of the CICD infrastructure depends on it.

Here are some resources about contributing to KinsonDigital projects:

Are you finished with this issue by chance? If you need more time, that is fine. Just curious so I know which release to put this into. 😉

Cheers!!

@ljdarj
Copy link
Contributor Author

ljdarj commented Nov 11, 2023

I'm finished with it, it was rather short. I'll keep in mind your remarks, I misunderstood the point in the documentation as to the branches' naming convention. And sorry for not answering earlier, I was rather busy all week ^^;

@CalvinWilkinson
Copy link
Member

I'm finished with it, it was rather short. I'll keep in mind your remarks, I misunderstood the point in the documentation as to the branches' naming convention. And sorry for not answering earlier, I was rather busy all week ^^;

Thanks for the reply and your contribution!! Not a problem. We all have personal lives and other responsibilities more important than contributing to my little projects. 🤣

I will take a look at it.

If you want to contribute more, you are always welcome to!!

One thing you could do if you don't mind, is when you create a pull request, create the PR as a draft PR that way I know it is not ready yet. Once you are finished, you can set the PR as ready for review which takes it out of draft mode.

This is all built into GitHub and is there to let people know if something is still being worked on or is ready for review and is complete.

Thanks!!

@CalvinWilkinson CalvinWilkinson merged commit f27ff8b into KinsonDigital:preview Nov 13, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority Low Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚧 Search and replace all equality checks with pattern matching
3 participants