Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Signoff] Confusing screen after having approved changes #317

Closed
n1k0 opened this issue Nov 15, 2016 · 0 comments · Fixed by #319
Closed

[Signoff] Confusing screen after having approved changes #317

n1k0 opened this issue Nov 15, 2016 · 0 comments · Fixed by #319
Labels

Comments

@n1k0
Copy link
Contributor

n1k0 commented Nov 15, 2016

This is what you get after you've approved changes as a reviewer:

screenshot at 16 44 42

This is rather confusing! /cc @leplatrem

Also, the notification message is confusing as well, it should probably say Changes approved, collection signature has been requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant